Skip to content

Updated go 1.17 -> 1.18 in template.yml #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Updated go 1.17 -> 1.18 in template.yml #79

wants to merge 1 commit into from

Conversation

Koeng101
Copy link
Contributor

@Koeng101 Koeng101 commented Jul 29, 2022

Description

I updated go 1.17 to 1.18 in template.yml. This is extremely minor, but I was really confused when I first saw the template.yml message and started looking for the right branch or git repo with 1.18, since I depend on generics.

How Has This Been Tested?

No changes to testing.

How are existing users impacted? What migration steps/scripts do we need?

They get up-to-date docs

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • read the CONTRIBUTION guide
  • signed-off my commits with git commit -s
  • added unit tests

@derek
Copy link

derek bot commented Jul 29, 2022

Thank you for your contribution. unfortunately, one or more of your commits are missing the required "Signed-off-by:" statement. Signing off is part of the Developer Certificate of Origin (DCO) which is used by this project.

Read the DCO and project contributing guide carefully, and amend your commits using the git CLI. Note that this does not require any cryptography, keys or special steps to be taken.

💡 Shall we fix this?

This will only take a few moments.

First, clone your fork and checkout this branch using the git CLI.

Next, set up your real name and email address:

git config --global user.name "Your Full Name"
git config --global user.email "[email protected]"

Finally, run one of these commands to add the "Signed-off-by" line to your commits.

If you only have one commit so far then run: git commit --amend --signoff and then git push --force.
If you have multiple commits, watch this video.

Check that the message has been added properly by running "git log".

@derek derek bot added the no-dco label Jul 29, 2022
@derek derek bot removed the no-dco label Jul 30, 2022
@Koeng101
Copy link
Contributor Author

That bot was... surprisingly helpful. I've now signed off on the change.

@welteki
Copy link
Member

welteki commented Aug 1, 2022

Hi @Koeng101

Thanks for reporting and fixing this. I also updated the other template in this repo.
Your changes are in #80.

Regards
Han

@alexellis alexellis closed this in #80 Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants