feat: upgrade to go 1.18 and use workspaces to manage the handler #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the custom bash script with a Go workspace, to handle setting the correct imports and replacements during the Go builds. This is simpler and uses offical Go tooling. Signed-off-by: Lucas Roesler <[email protected]>
LucasRoesler
force-pushed
the
feat-upgrade-to-1.18-and-use-workspaces
branch
from
8363e4c to
9a051b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the custom bash script with a Go workspace, to handle setting the correct imports and replacements during the Go builds. This is simpler and uses official Go tooling.
How Has This Been Tested?
I have started a repo of test functions here: https://github.com/LucasRoesler/golang-http-template-examples
The first example
publisheris an examplego-httpfunction that publishes messages to a NATS subject. This function demonstrates usinggit.colasdn.top/nats-io/nats.goandgit.colasdn.top/openfaas/templates-sdk/go-httppkg/versionHow are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have:
git commit -s