Skip to content

feat: upgrade to go 1.18 and use workspaces to manage the handler #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

LucasRoesler
Copy link
Member

@LucasRoesler LucasRoesler commented Apr 9, 2022

Replace the custom bash script with a Go workspace, to handle setting the correct imports and replacements during the Go builds. This is simpler and uses official Go tooling.

How Has This Been Tested?

I have started a repo of test functions here: https://github.com/LucasRoesler/golang-http-template-examples

The first example publisher is an example go-http function that publishes messages to a NATS subject. This function demonstrates using

  • external public packages: github.com/nats-io/nats.go and github.com/openfaas/templates-sdk/go-http
  • it contains a named subpackage pkg/version

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • read the CONTRIBUTION guide
  • signed-off my commits with git commit -s
  • added unit tests

@LucasRoesler LucasRoesler marked this pull request as ready for review April 9, 2022 18:03
Replace the custom bash script with a Go workspace, to handle setting
the correct imports and replacements during the Go builds. This is
simpler and uses offical Go tooling.

Signed-off-by: Lucas Roesler <[email protected]>
@LucasRoesler LucasRoesler force-pushed the feat-upgrade-to-1.18-and-use-workspaces branch from 8363e4c to 9a051b2 Compare April 9, 2022 18:25
Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@alexellis alexellis merged commit 193d979 into openfaas:master Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants