Skip to content

go-selinux: retry on EINTR #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2020
Merged

Conversation

kolyshkin
Copy link
Collaborator

Wrap some syscalls (lgetattr, lsetattr, fstatfs, statfs)
to retry on EINTR, just in case.

Related:

@rhatdan
Copy link
Collaborator

rhatdan commented Nov 6, 2020

LGTM
@thaJeztah @vrothberg @saschagrunert @mrunalp PTAL

Approved with PullApprove

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Change itself looks good; left some thoughts (happy to get your input, as always)

Wrap some syscalls (lgetattr, lsetattr, fstatfs, statfs)
to retry on EINTR.

Related:
 - containers/storage#757
 - https://go-review.googlesource.com/c/go/+/249178
 - golang/go#38033

Signed-off-by: Kir Kolyshkin <[email protected]>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thaJeztah
Copy link
Member

thaJeztah commented Nov 6, 2020

LGTM

Approved with PullApprove

@rhatdan rhatdan merged commit df3f9df into opencontainers:master Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants