Skip to content

fix: Respect required field in parameters included with $ref #737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2023

Conversation

robertschweizer
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Mar 18, 2023

Codecov Report

Merging #737 (fe03131) into main (302cd02) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #737   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           49        49           
  Lines         1971      1971           
=========================================
  Hits          1971      1971           
Impacted Files Coverage Δ
openapi_python_client/parser/properties/schemas.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@dbanty dbanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Not sure what I was thinking with the old way, I can't think of a reason to hard-code True 😅

@dbanty dbanty merged commit 555ff10 into openapi-generators:main Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants