Skip to content

fix: If data.type is None but has data.properties, assume type is object #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 12, 2022

Conversation

ahuang11
Copy link
Contributor

@ahuang11 ahuang11 commented Oct 21, 2022

Closes #674

Not entirely sure if I did the end to end testing correctly since I got:

end_to_end_tests: task regen
Generating my-test-api-client

Usage: openapi-python-client update [OPTIONS]
Try 'openapi-python-client update --help' for help.
╭─ Error ────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
│ Invalid value: Unable to parse config

But it generated the test files and the task e2e succeeded.

@ahuang11 ahuang11 changed the title If data.type is None but has data.properties, assum type is object fix: If data.type is None but has data.properties, assume type is object Oct 21, 2022
@codecov
Copy link

codecov bot commented Nov 12, 2022

Codecov Report

Merging #691 (b91bed3) into main (9b983a0) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #691   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           49        49           
  Lines         1946      1946           
=========================================
  Hits          1946      1946           
Impacted Files Coverage Δ
...penapi_python_client/parser/properties/__init__.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dbanty
Copy link
Collaborator

dbanty commented Nov 12, 2022

Looks great, thanks for fixing this!!

@dbanty dbanty merged commit d4e14f9 into openapi-generators:main Nov 12, 2022
@dbanty dbanty added this to the 0.12.0 milestone Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot take allOf a non-object
2 participants