fix: Allow tokenUrl to be relative #618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like the change before: openapi-generators@15c2fd5#diff-1a1a2865f336a376229eaffe0f56caac01c7a3a77602e07fe4a38fd550c6c318 Has been reverted: openapi-generators@0101a03#diff-6676609c9c37705f6953ffcc9eb6d33164df50f241d4844c5665cf5ff4305995R16 As mentioned, relative URLs are supported in OpenAPI 3.0+: swagger-api/swagger-ui#5243
dbanty
requested changes
Jun 3, 2022
Codecov Report
@@ Coverage Diff @@
## main #618 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 49 49
Lines 1713 1713
=========================================
Hits 1713 1713
Continue to review full report at Codecov.
|
|
Just ran into this issue with fastapi-users usage . Will this be added to an official release soon? Thanks. @dbanty |
dbanty
changed the title
All set 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the change before:
15c2fd5#diff-1a1a2865f336a376229eaffe0f56caac01c7a3a77602e07fe4a38fd550c6c318
Has been reverted:
0101a03#diff-6676609c9c37705f6953ffcc9eb6d33164df50f241d4844c5665cf5ff4305995R16
As mentioned, relative URLs are supported in OpenAPI 3.0+:
swagger-api/swagger-ui#5243