-
-
Notifications
You must be signed in to change notification settings - Fork 229
fix: Include nested packages in generated setup.py (closes #575) #576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…#575) When openapi-python-client is used to with the --meta=setup option the generated setup.py needs to use setuptools.find_packages() to find the top-level and all of the nested pacakges in the directory so that distributions include them
Codecov Report
@@ Coverage Diff @@
## main #576 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 49 49
Lines 1713 1713
=========================================
Hits 1713 1713 Continue to review full report at Codecov.
|
Before:
After
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though I'm mostly leaning on your experience since I don't use setup.py
😁
When openapi-python-client is used to with the
--meta=setup option the generated setup.py needs to
use setuptools.find_packages() to find the top-level
and all of the nested pacakges in the directory
so that distributions include them