Skip to content

feat: add option to not prepend path to Model Classes with title names #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

rtaycher
Copy link
Contributor

Pairs with/would close #559

@codecov
Copy link

codecov bot commented Dec 31, 2021

Codecov Report

Merging #560 (ef44f8e) into main (dd81e19) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #560   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           49        49           
  Lines         1962      1966    +4     
=========================================
+ Hits          1962      1966    +4     
Impacted Files Coverage Δ
openapi_python_client/config.py 100.00% <100.00%> (ø)
..._python_client/parser/properties/model_property.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@dbanty dbanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just need a test to cover the new case.

@rtaycher
Copy link
Contributor Author

Hi sorry @dbanty I'm a little lost on how to add a test for this. Any guidance would be appreciated. Thanks.

@dbanty
Copy link
Collaborator

dbanty commented Dec 17, 2022

Sorry for the long delay getting back to this one, thanks @rtaycher!

@dbanty dbanty enabled auto-merge (squash) December 17, 2022 23:35
@dbanty dbanty disabled auto-merge December 17, 2022 23:35
@dbanty dbanty merged commit 99638b1 into openapi-generators:main Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't prepend title based property names, use Titles for full model type names
2 participants