Skip to content

Feature/custom package names #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 6, 2020

Conversation

emann
Copy link
Collaborator

@emann emann commented Aug 5, 2020

Closes #123

@codecov
Copy link

codecov bot commented Aug 5, 2020

Codecov Report

Merging #133 into main will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #133   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           40        41    +1     
  Lines         1159      1177   +18     
=========================================
+ Hits          1159      1177   +18     
Impacted Files Coverage Δ
openapi_python_client/__init__.py 100.00% <100.00%> (ø)
openapi_python_client/cli.py 100.00% <100.00%> (ø)
openapi_python_client/config.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9587f59...e360b7e. Read the comment docs.

Copy link
Collaborator

@dbanty dbanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the biggest concern is that you need to rebase / merge main into this and verify it still works. I know yaml will be required.

@emann emann force-pushed the feature/custom-package-names branch from 8bbb147 to caf8e50 Compare August 6, 2020 14:25
Copy link
Collaborator

@dbanty dbanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@dbanty dbanty merged commit 3227f78 into openapi-generators:main Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support custom client package names
2 participants