Skip to content

Make this project source installable via Pip #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dbanty opened this issue Aug 4, 2020 · 3 comments
Closed

Make this project source installable via Pip #121

dbanty opened this issue Aug 4, 2020 · 3 comments
Labels
✨ enhancement New feature or improvement

Comments

@dbanty
Copy link
Collaborator

dbanty commented Aug 4, 2020

Is your feature request related to a problem? Please describe.
Originally requested by @TMiguelT in #119. The goal is to be able to pip install -U git+https://github.com/triaxtec/openapi-python-client.git.

Describe the solution you'd like
Auto-generate a setup.py from pyproject.toml using GitHub Actions so it's kept up to date.

Additional context
This will probably also make this installable via pipx from source.

@dbanty dbanty added the ✨ enhancement New feature or improvement label Aug 4, 2020
@multimeric
Copy link

As I said elsewhere, I think with pip 19.0 onwards, this should just work automatically, as long as you define the [build-system] section correctly: https://pip.pypa.io/en/stable/reference/pip/#pep-517-and-518-support. Because then pip understands that it needs poetry in order to build the package.

@dbanty
Copy link
Collaborator Author

dbanty commented Aug 5, 2020

Oh interesting, I knew it could read some data from pyproject.toml but didn't realize you could tell it to require packages. I'll give this a shot for sure.

@dbanty
Copy link
Collaborator Author

dbanty commented Aug 5, 2020

Awesome, it works! Thanks @TMiguelT, I'll probably do something similar for #120 in the short term too.

@dbanty dbanty closed this as completed Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement New feature or improvement
Projects
None yet
Development

No branches or pull requests

2 participants