-
-
Notifications
You must be signed in to change notification settings - Fork 229
refuses to generate valid allOf combinations #1083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks @eli-bl . I'm not actually sure if this fixes the issue I was seeing, hopefully it does. I found this big near the end of my time at my previous job and filed a simplified version of what I was seeing after I had moved on and no longer had access to the source yaml (plus a simpler example is better right?). Hopefully your fix helps the person who inherited my openapi tasks. |
@dbanty, I'll close this - it does seem to have been fixed as described above. |
Describe the bug
My understanding of allOf is that its supposed to recursively combine 2+ dictionaries and only fail if multiple types cant be satisfied(such as if the same path has different types assigned). At first I thought it didn't like it if subdictionaries had different values but then I realized other openapi tools validated it and it didn't have conflicts.
I managed to cut down the example and even having the same two subdicts with the same name triggers the error
openapi-example.yaml.json because github doesnt like yaml
rename to yaml and run
openapi-python-client generate --path openapi-example
to verify.https://editor.swagger.io/ validates it and will even let you generate official swagger client with this example
OpenAPI Spec File
A link to an OpenAPI document which produces this issue. Ideally, write a minimal reproduction only containing the problematic pieces.
Additional context
result
Also apparently ommitted is a misspelling and it should be omitted
The text was updated successfully, but these errors were encountered: