Fix PascalCase transformation from Title Case. Fixes #271

Author: dbanty

openapi_python_client/parser/reference.py

@@ -19,8 +19,7 @@ class Reference:
     def from_ref(ref: str) -> "Reference":
         """ Get a Reference from the openapi #/schemas/blahblah string """
         ref_value = ref.split("/")[-1]
-        # ugly hack to avoid stringcase ugly pascalcase output when ref_value isn't snake case
-        class_name = utils.pascal_case(ref_value.replace(" ", ""))
+        class_name = utils.pascal_case(ref_value)
 
         if class_name in class_overrides:
             return class_overrides[class_name]

openapi_python_client/utils.py

@@ -26,7 +26,7 @@ def snake_case(value: str) -> str:
 
 
 def pascal_case(value: str) -> str:
-    return fix_keywords(stringcase.pascalcase(sanitize(value)))
+    return fix_keywords(stringcase.pascalcase(sanitize(value.replace(" ", ""))))
 
 
 def kebab_case(value: str) -> str:

tests/test_utils.py

@@ -1,3 +1,5 @@
+import pytest
+
 from openapi_python_client import utils
 
 
@@ -41,3 +43,16 @@ def test_to_valid_python_identifier():
     assert utils.to_valid_python_identifier("1") == "field_1"
     assert utils.to_valid_python_identifier("$") == "field_"
     assert utils.to_valid_python_identifier("for") == "for_"
+
+
+@pytest.mark.parametrize(
+    "before, after",
+    [
+        ("PascalCase", "PascalCase"),
+        ("snake_case", "SnakeCase"),
+        ("TLAClass", "TLAClass"),
+        ("Title Case", "TitleCase"),
+    ],
+)
+def test_pascalcase(before, after):
+    assert utils.pascal_case(before) == after