Skip to content

Commit f64bec6

Browse files
fix(client): only call .close() when needed (#1992)
1 parent 759505d commit f64bec6

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

src/openai/_base_client.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -768,6 +768,9 @@ def __init__(self, **kwargs: Any) -> None:
768768

769769
class SyncHttpxClientWrapper(DefaultHttpxClient):
770770
def __del__(self) -> None:
771+
if self.is_closed:
772+
return
773+
771774
try:
772775
self.close()
773776
except Exception:
@@ -1350,6 +1353,9 @@ def __init__(self, **kwargs: Any) -> None:
13501353

13511354
class AsyncHttpxClientWrapper(DefaultAsyncHttpxClient):
13521355
def __del__(self) -> None:
1356+
if self.is_closed:
1357+
return
1358+
13531359
try:
13541360
# TODO(someday): support non asyncio runtimes here
13551361
asyncio.get_running_loop().create_task(self.aclose())

0 commit comments

Comments
 (0)