Skip to content

Commit ed8f82c

Browse files
committed
Fix memory leak
1 parent 3f7981c commit ed8f82c

File tree

6 files changed

+11
-12
lines changed

6 files changed

+11
-12
lines changed

src/binding/python/Iteration.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ void init_Iteration(py::module &m)
114114
add_pickle(
115115
cl, [](openPMD::Series series, std::vector<std::string> const &group) {
116116
uint64_t const n_it = std::stoull(group.at(1));
117-
auto &res = series.iterations[n_it];
117+
auto res = series.iterations[n_it];
118118
return internal::makeOwning(res, std::move(series));
119119
});
120120

src/binding/python/Mesh.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ void init_Mesh(py::module &m)
117117
add_pickle(
118118
cl, [](openPMD::Series series, std::vector<std::string> const &group) {
119119
uint64_t const n_it = std::stoull(group.at(1));
120-
auto &res = series.iterations[n_it].open().meshes[group.at(3)];
120+
auto res = series.iterations[n_it].open().meshes[group.at(3)];
121121
return internal::makeOwning(res, std::move(series));
122122
});
123123

src/binding/python/MeshRecordComponent.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ void init_MeshRecordComponent(py::module &m)
8484
add_pickle(
8585
cl, [](openPMD::Series series, std::vector<std::string> const &group) {
8686
uint64_t const n_it = std::stoull(group.at(1));
87-
auto &res =
87+
auto res =
8888
series.iterations[n_it]
8989
.open()
9090
.meshes[group.at(3)]

src/binding/python/ParticleSpecies.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ void init_ParticleSpecies(py::module &m)
5757
add_pickle(
5858
cl, [](openPMD::Series series, std::vector<std::string> const &group) {
5959
uint64_t const n_it = std::stoull(group.at(1));
60-
ParticleSpecies &res =
60+
ParticleSpecies res =
6161
series.iterations[n_it].open().particles[group.at(3)];
6262
return internal::makeOwning(res, std::move(series));
6363
});

src/binding/python/Record.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,8 +74,8 @@ void init_Record(py::module &m)
7474
add_pickle(
7575
cl, [](openPMD::Series series, std::vector<std::string> const &group) {
7676
uint64_t const n_it = std::stoull(group.at(1));
77-
auto &res = series.iterations[n_it].open().particles[group.at(3)]
78-
[group.at(4)];
77+
auto res = series.iterations[n_it].open().particles[group.at(3)]
78+
[group.at(4)];
7979
return internal::makeOwning(res, std::move(series));
8080
});
8181

src/binding/python/RecordComponent.cpp

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1124,12 +1124,11 @@ void init_RecordComponent(py::module &m)
11241124
add_pickle(
11251125
cl, [](openPMD::Series series, std::vector<std::string> const &group) {
11261126
uint64_t const n_it = std::stoull(group.at(1));
1127-
auto &res =
1128-
series.iterations[n_it]
1129-
.open()
1130-
.particles[group.at(3)][group.at(4)]
1131-
[group.size() < 6 ? RecordComponent::SCALAR
1132-
: group.at(5)];
1127+
auto res = series.iterations[n_it]
1128+
.open()
1129+
.particles[group.at(3)][group.at(4)]
1130+
[group.size() < 6 ? RecordComponent::SCALAR
1131+
: group.at(5)];
11331132
return internal::makeOwning(res, std::move(series));
11341133
});
11351134

0 commit comments

Comments
 (0)