Allow passing a custom random number generator to trace.RandomIdGenerator #4571
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I am using OpenTelemetry to trace gRPC calls in my distributed machine learning application, and I fixed the global random seed in all replicas via
random.seed(42)
to make the application's result reproducible; but, it causes duplicate trace and span ids rendering the traces corrupt.This PR adds the possibility to create/use an instance of
trace.RandomIdGenerator
that utilizes a custom random number generator instance (e.g.random.Random()
); It preserves backward compatibility and previous users expectations by defaulting to the global random instance as before.Fixes #4376.
Type of change
How Has This Been Tested?
To reproduce my use-case, write a Python script with the following pseudo-algorithm:
Does This PR Require a Contrib Repo Change?
Checklist: