Skip to content

Commit 298cc1e

Browse files
committed
Test consume_measurement is called for async instrument
1 parent 45d7a71 commit 298cc1e

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

opentelemetry-sdk/tests/metrics/test_measurement_consumer.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ def test_collect_calls_async_instruments(self, MockMetricReaderStorage):
100100
MockMetricReaderStorage.return_value = reader_storage_mock
101101
consumer = SynchronousMeasurementConsumer(
102102
SdkConfiguration(
103-
exemplar_filter=Mock(),
103+
exemplar_filter=Mock(should_sample=Mock(return_value=False)),
104104
resource=Mock(),
105105
metric_readers=[reader_mock],
106106
views=Mock(),
@@ -121,6 +121,9 @@ def test_collect_calls_async_instruments(self, MockMetricReaderStorage):
121121
self.assertEqual(
122122
len(reader_storage_mock.consume_measurement.mock_calls), 5
123123
)
124+
# assert consume_measurement was called with at least 2 arguments the second
125+
# matching the mocked exemplar filter
126+
self.assertFalse(reader_storage_mock.consume_measurement.call_args[1])
124127

125128
def test_collect_timeout(self, MockMetricReaderStorage):
126129
reader_mock = Mock()

0 commit comments

Comments
 (0)