Skip to content

Introducing tox-uv #3185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 17, 2025
Merged

Introducing tox-uv #3185

merged 3 commits into from
Jan 17, 2025

Conversation

emdneto
Copy link
Member

@emdneto emdneto commented Jan 14, 2025

Description

after some rework, I'm opening another PR with less intrusive changes to the tox.ini file. Basically, this is a new version of the work from #2667

uv makes pip install faster. It works like this: uv pip install and we can have tests running faster locally and in CI. The tool is from the creators of ruff.

The main improvement I see here is the Dependency caching and fast resolution of packages during pip install. We can benefit from this for local development to avoid slow tests, mainly the git clones in contrib tests.

This PR also introduces the usage of tox-uv which is a tox plugin that supports venv runner with uv.

@emdneto emdneto requested a review from a team as a code owner January 14, 2025 14:11
@emdneto emdneto added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 14, 2025
Copy link
Contributor

@Kludex Kludex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For curiosity, did you check how much performance benefit there is here?

@xrmx
Copy link
Contributor

xrmx commented Jan 14, 2025

For curiosity, did you check how much performance benefit there is here?

Completely unscientific but looks like on CI two test workflows out of three are a few minutes faster

@Kludex
Copy link
Contributor

Kludex commented Jan 14, 2025

Unscientific is good. I was lazy to look. 😐👍

Few minutes is great.

@xrmx xrmx merged commit 9b217bb into open-telemetry:main Jan 17, 2025
675 checks passed
xrmx pushed a commit to xrmx/opentelemetry-python-contrib that referenced this pull request Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants