update tests

Author: danielhochman

instrumentation/opentelemetry-instrumentation-asgi/tests/test_asgi_middleware.py

@@ -21,6 +21,8 @@
 from timeit import default_timer
 from unittest import mock
 
+import pytest
+
 import opentelemetry.instrumentation.asgi as otel_asgi
 from opentelemetry import trace as trace_api
 from opentelemetry.instrumentation.propagators import (
@@ -752,52 +754,64 @@ def test_asgi_metrics(self):
                             )
         self.assertTrue(number_data_point_seen and histogram_data_point_seen)
 
-    def test_basic_metric_success(self):
-        app = otel_asgi.OpenTelemetryMiddleware(simple_asgi)
-        self.seed_app(app)
-        start = default_timer()
-        self.send_default_request()
-        duration = max(round((default_timer() - start) * 1000), 0)
-        expected_duration_attributes = {
-            "http.method": "GET",
-            "http.host": "127.0.0.1",
-            "http.scheme": "http",
-            "http.flavor": "1.0",
-            "net.host.port": 80,
-            "http.status_code": 200,
-        }
-        expected_requests_count_attributes = {
-            "http.method": "GET",
-            "http.host": "127.0.0.1",
-            "http.scheme": "http",
-            "http.flavor": "1.0",
-        }
-        metrics_list = self.memory_metrics_reader.get_metrics_data()
-        # pylint: disable=too-many-nested-blocks
-        for resource_metric in metrics_list.resource_metrics:
-            for scope_metrics in resource_metric.scope_metrics:
-                for metric in scope_metrics.metrics:
-                    for point in list(metric.data.data_points):
-                        if isinstance(point, HistogramDataPoint):
-                            self.assertDictEqual(
-                                expected_duration_attributes,
-                                dict(point.attributes),
-                            )
-                            self.assertEqual(point.count, 1)
-                            if metric.name == "http.server.duration":
-                                self.assertAlmostEqual(
-                                    duration, point.sum, delta=5
+    @pytest.mark.parametrize(
+        "span_recording",
+        [True, False],
+    )
+    def test_basic_metric_success(self, span_recording):
+        mock_tracer = mock.Mock()
+        mock_span = mock.Mock()
+        mock_span.is_recording.return_value = span_recording
+        mock_tracer.start_as_current_span.return_value = mock_span
+        mock_tracer.start_as_current_span.return_value.__enter__ = mock_span
+        mock_tracer.start_as_current_span.return_value.__exit__ = mock_span
+        with mock.patch("opentelemetry.trace.get_tracer") as tracer:
+            tracer.return_value = mock_tracer
+            app = otel_asgi.OpenTelemetryMiddleware(simple_asgi)
+            self.seed_app(app)
+            start = default_timer()
+            self.send_default_request()
+            duration = max(round((default_timer() - start) * 1000), 0)
+            expected_duration_attributes = {
+                "http.method": "GET",
+                "http.host": "127.0.0.1",
+                "http.scheme": "http",
+                "http.flavor": "1.0",
+                "net.host.port": 80,
+                "http.status_code": 200,
+            }
+            expected_requests_count_attributes = {
+                "http.method": "GET",
+                "http.host": "127.0.0.1",
+                "http.scheme": "http",
+                "http.flavor": "1.0",
+            }
+            metrics_list = self.memory_metrics_reader.get_metrics_data()
+            # pylint: disable=too-many-nested-blocks
+            for resource_metric in metrics_list.resource_metrics:
+                for scope_metrics in resource_metric.scope_metrics:
+                    for metric in scope_metrics.metrics:
+                        for point in list(metric.data.data_points):
+                            if isinstance(point, HistogramDataPoint):
+                                self.assertDictEqual(
+                                    expected_duration_attributes,
+                                    dict(point.attributes),
                                 )
-                            elif metric.name == "http.server.response.size":
-                                self.assertEqual(1024, point.sum)
-                            elif metric.name == "http.server.request.size":
-                                self.assertEqual(128, point.sum)
-                        elif isinstance(point, NumberDataPoint):
-                            self.assertDictEqual(
-                                expected_requests_count_attributes,
-                                dict(point.attributes),
-                            )
-                            self.assertEqual(point.value, 0)
+                                self.assertEqual(point.count, 1)
+                                if metric.name == "http.server.duration":
+                                    self.assertAlmostEqual(
+                                        duration, point.sum, delta=5
+                                    )
+                                elif metric.name == "http.server.response.size":
+                                    self.assertEqual(1024, point.sum)
+                                elif metric.name == "http.server.request.size":
+                                    self.assertEqual(128, point.sum)
+                            elif isinstance(point, NumberDataPoint):
+                                self.assertDictEqual(
+                                    expected_requests_count_attributes,
+                                    dict(point.attributes),
+                                )
+                                self.assertEqual(point.value, 0)
 
     def test_metric_target_attribute(self):
         expected_target = "/api/user/{id}"