Skip to content

Commit e47330b

Browse files
committed
instruments-any and _instruments_any
1 parent acac105 commit e47330b

File tree

10 files changed

+17
-19
lines changed

10 files changed

+17
-19
lines changed

CHANGELOG.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
3030
([#3508](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3508))
3131
- `opentelemetry-instrumentation-pymongo` `aggregate` and `getMore` capture statements support
3232
([#3601](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3601))
33-
- `opentelemetry-instrumentation-fastapi` Utilize instruments_either functionality.
33+
- `opentelemetry-instrumentation-fastapi` Utilize instruments-any functionality.
3434
([#3612](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3612))
35-
- `opentelemetry-instrumentation-psycopg2` Utilize instruments_either functionality.
35+
- `opentelemetry-instrumentation-psycopg2` Utilize instruments-any functionality.
3636
([#3612](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3612))
37-
- `opentelemetry-instrumentation-kafka-python` Utilize instruments_either functionality.
37+
- `opentelemetry-instrumentation-kafka-python` Utilize instruments-any functionality.
3838
([#3612](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3612))
3939

4040
## Version 1.34.0/0.55b0 (2025-06-04)

instrumentation/opentelemetry-instrumentation-fastapi/pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ dependencies = [
3434

3535
[project.optional-dependencies]
3636
instruments = []
37-
instruments_either = [
37+
instruments-any = [
3838
"fastapi ~= 0.92",
3939
"fastapi-slim ~= 0.92",
4040
]

instrumentation/opentelemetry-instrumentation-fastapi/src/opentelemetry/instrumentation/fastapi/package.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
# TODO: update this
1717
_instruments = ()
18-
_instruments_either = ("fastapi ~= 0.92", "fastapi-slim ~= 0.92")
18+
_instruments_any = ("fastapi ~= 0.92", "fastapi-slim ~= 0.92")
1919

2020
_supports_metrics = True
2121

instrumentation/opentelemetry-instrumentation-kafka-python/pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ dependencies = [
3232

3333
[project.optional-dependencies]
3434
instruments = []
35-
instruments_either = [
35+
instruments-any = [
3636
"kafka-python >= 2.0, < 3.0",
3737
"kafka-python-ng >= 2.0, < 3.0"
3838
]

instrumentation/opentelemetry-instrumentation-kafka-python/src/opentelemetry/instrumentation/kafka/package.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,4 +18,4 @@
1818
_instruments_kafka_python_ng = "kafka-python-ng >= 2.0, < 3.0"
1919

2020
_instruments = ()
21-
_instruments_either = (_instruments_kafka_python, _instruments_kafka_python_ng)
21+
_instruments_any = (_instruments_kafka_python, _instruments_kafka_python_ng)

instrumentation/opentelemetry-instrumentation-psycopg2/pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ dependencies = [
3232

3333
[project.optional-dependencies]
3434
instruments = []
35-
instruments_either = [
35+
instruments-any = [
3636
"psycopg2 >= 2.7.3.1",
3737
"psycopg2-binary >= 2.7.3.1",
3838
]

instrumentation/opentelemetry-instrumentation-psycopg2/src/opentelemetry/instrumentation/psycopg2/package.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,9 @@
1717
_instruments_psycopg2 = "psycopg2 >= 2.7.3.1"
1818
_instruments_psycopg2_binary = "psycopg2-binary >= 2.7.3.1"
1919

20-
# TODO: maybe add _instruments_either
20+
# TODO: maybe add _instruments_any
2121
_instruments = ()
22-
_instruments_either = (
22+
_instruments_any = (
2323
_instruments_psycopg2,
2424
_instruments_psycopg2_binary,
2525
)

scripts/generate_instrumentation_bootstrap.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ def main():
8484
pkg_name = pkg.get("name")
8585
if pkg_name in packages_to_exclude:
8686
continue
87-
if not pkg["instruments"] and not pkg["instruments_either"]:
87+
if not pkg["instruments"] and not pkg["instruments-any"]:
8888
default_instrumentations.elts.append(ast.Str(pkg["requirement"]))
8989
for target_pkg in pkg["instruments"]:
9090
libraries.elts.append(
@@ -93,7 +93,7 @@ def main():
9393
values=[ast.Str(target_pkg), ast.Str(pkg["requirement"])],
9494
)
9595
)
96-
for target_pkg in pkg["instruments_either"]:
96+
for target_pkg in pkg["instruments-any"]:
9797
libraries.elts.append(
9898
ast.Dict(
9999
keys=[ast.Str("library"), ast.Str("instrumentation")],

scripts/generate_instrumentation_readme.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,14 +59,14 @@ def main(base_instrumentation_path):
5959
exec(fh.read(), pkg_info)
6060

6161
instruments_and = pkg_info.get("_instruments", ())
62-
instruments_either = pkg_info.get("_instruments_either", ())
62+
instruments_any = pkg_info.get("_instruments_any", ())
6363
supports_metrics = pkg_info.get("_supports_metrics")
6464
semconv_status = pkg_info.get("_semconv_status")
6565
instruments_all = ()
66-
if not instruments_and and not instruments_either:
66+
if not instruments_and and not instruments_any:
6767
instruments_all = (name,)
6868
else:
69-
instruments_all = tuple(instruments_and + instruments_either)
69+
instruments_all = tuple(instruments_and + instruments_any)
7070

7171
if not semconv_status:
7272
semconv_status = "development"

scripts/otel_packaging.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -64,14 +64,12 @@ def get_instrumentation_packages(
6464
"optional-dependencies"
6565
]
6666
instruments = optional_dependencies.get("instruments", [])
67-
instruments_either = optional_dependencies.get(
68-
"instruments_either", []
69-
)
67+
instruments_any = optional_dependencies.get("instruments-any", [])
7068
instrumentation = {
7169
"name": pyproject_toml["project"]["name"],
7270
"version": version.strip(),
7371
"instruments": instruments,
74-
"instruments_either": instruments_either,
72+
"instruments-any": instruments_any,
7573
}
7674
if instrumentation["name"] in independent_packages:
7775
specifier = independent_packages[instrumentation["name"]]

0 commit comments

Comments
 (0)