adding relationship assertion

Author: rbizos

exporter/opentelemetry-exporter-richconsole/src/opentelemetry/exporter/richconsole/__init__.py

@@ -73,6 +73,7 @@ def _ns_to_time(nanoseconds):
 
 
 def _child_to_tree(child: Tree, span: ReadableSpan):
+    print(span.name)
     child.add(
         Text.from_markup(f"[bold cyan]Kind :[/bold cyan] {span.kind.name}")
     )
@@ -152,15 +153,13 @@ def export(self, spans: typing.Sequence[ReadableSpan]) -> SpanExportResult:
         if not spans:
             return SpanExportResult.SUCCESS
 
-        for tree in self.spans_to_tree(spans):
+        for tree in self.spans_to_tree(spans).values():
             self.console.print(tree)
 
         return SpanExportResult.SUCCESS
 
     @staticmethod
-    def spans_to_tree(
-        self, spans: typing.Sequence[ReadableSpan]
-    ) -> Dict[str, Tree]:
+    def spans_to_tree(spans: typing.Sequence[ReadableSpan]) -> Dict[str, Tree]:
         trees = dict()
         all_parent_ids = {span.context.span_id for span in spans}
         parents = {}

exporter/opentelemetry-exporter-richconsole/tests/test_rich_exporter.py

@@ -17,7 +17,10 @@
 from opentelemetry.exporter.richconsole import RichConsoleSpanExporter
 from opentelemetry.sdk import trace
 from opentelemetry.sdk.trace import ReadableSpan
-from opentelemetry.sdk.trace.export import BatchSpanProcessor
+from opentelemetry.sdk.trace.export import (
+    BatchSpanProcessor,
+    SimpleSpanProcessor,
+)
 import opentelemetry.trace
 from rich.tree import Tree
 
@@ -43,10 +46,12 @@ def fixture_tracer_provider(span_processor):
 def test_span_exporter(tracer_provider, span_processor, capsys):
     tracer = tracer_provider.get_tracer(__name__)
     span = tracer.start_span("test_span")
+
     span.set_attribute("key", "V4LuE")
     span.end()
     span_processor.force_flush()
     captured = capsys.readouterr()
+
     assert "V4LuE" in captured.out
 
 
@@ -70,12 +75,36 @@ def test_multiple_traces(tracer_provider):
     trees = exporter.spans_to_tree((parent_2, parent_1, child_1))
     # asserts that we have all traces
     assert len(trees) == 2
-    assert (
-        opentelemetry.trace.format_trace_id(parent_1.context.trace_id) in trees
-    )
+    traceid_1 = opentelemetry.trace.format_trace_id(parent_1.context.trace_id)
+
+    assert traceid_1 in trees
+
     assert (
         opentelemetry.trace.format_trace_id(parent_2.context.trace_id) in trees
     )
 
     # asserts that we have exactly the number of spans we exported
     assert sum([walk_tree(tree) for tree in trees.values()]) == 3
+
+    # assert that the relationship is correct
+    assert parent_1.name in trees[traceid_1].children[0].label
+    assert any(
+        [
+            child_1.name in child.label
+            for child in trees[traceid_1].children[0].children
+        ]
+    )
+    assert not any(
+        [
+            parent_1.name in child.label
+            for child in trees[traceid_1].children[0].children
+        ]
+    )
+    assert not any(
+        [
+            parent_2.name in child.label
+            for child in trees[traceid_1].children[0].children
+        ]
+    )
+
+    assert trees[traceid_1].children