Fixed urllib3 instrumentation example in instrumentation documentation (#1793)

yashaswi2000 · shalevr · ocelotl · web-flow · commit a3a0b2409cc1 · 2023-06-16T23:08:51.000Z
* corrected instrumentation example in urllib3

* Remove changelog entry

---------

Co-authored-by: Shalev Roda &lt;65566801+shalevr@users.noreply.github.com&gt;
Co-authored-by: Diego Hurtado &lt;ocelotl@users.noreply.github.com&gt;
diff --git a/instrumentation/opentelemetry-instrumentation-urllib3/README.rst b/instrumentation/opentelemetry-instrumentation-urllib3/README.rst
@@ -38,8 +38,8 @@ The hooks can be configured as follows:
     def response_hook(span, request, response):
         pass
 
-    URLLib3Instrumentor.instrument(
-        request_hook=request_hook, response_hook=response_hook)
+    URLLib3Instrumentor().instrument(
+        request_hook=request_hook, response_hook=response_hook
     )
 
 Exclude lists
diff --git a/instrumentation/opentelemetry-instrumentation-urllib3/src/opentelemetry/instrumentation/urllib3/__init__.py b/instrumentation/opentelemetry-instrumentation-urllib3/src/opentelemetry/instrumentation/urllib3/__init__.py
@@ -56,8 +56,8 @@ def request_hook(span, request):
     def response_hook(span, request, response):
         pass
 
-    URLLib3Instrumentor.instrument(
-        request_hook=request_hook, response_hook=response_hook)
+    URLLib3Instrumentor().instrument(
+        request_hook=request_hook, response_hook=response_hook
     )
 
 Exclude lists

Original file line number	Diff line number	Diff line change
`@@ -38,8 +38,8 @@ The hooks can be configured as follows:`
`38`	`38`	`def response_hook(span, request, response):`
`39`	`39`	`pass`
`40`	`40`
`41`		`- URLLib3Instrumentor.instrument(`
`42`		`- request_hook=request_hook, response_hook=response_hook)`
	`41`	`+ URLLib3Instrumentor().instrument(`
	`42`	`+ request_hook=request_hook, response_hook=response_hook`
`43`	`43`	`)`
`44`	`44`
`45`	`45`	`Exclude lists`
Original file line number	Diff line number	Diff line change
`@@ -56,8 +56,8 @@ def request_hook(span, request):`
`56`	`56`	`def response_hook(span, request, response):`
`57`	`57`	`pass`
`58`	`58`
`59`		`- URLLib3Instrumentor.instrument(`
`60`		`- request_hook=request_hook, response_hook=response_hook)`
	`59`	`+ URLLib3Instrumentor().instrument(`
	`60`	`+ request_hook=request_hook, response_hook=response_hook`
`61`	`61`	`)`
`62`	`62`
`63`	`63`	`Exclude lists`