Reverse the boolean re-raise -> swallow, assert on the excpeted message

Author: phillipuniverse

opentelemetry-instrumentation/src/opentelemetry/instrumentation/auto_instrumentation/__init__.py

@@ -118,11 +118,11 @@ def run() -> None:
     execl(executable, executable, *args.command_args)
 
 
-def initialize(*, reraise=False):
+def initialize(*, swallow_exceptions=True):
     """
     Setup auto-instrumentation, called by the sitecustomize module
 
-    :param reraise: Whether or not to re-raise exceptions in the auto-instrumentation process to the caller. Exceptions are logged and swalloed by default.
+    :param swallow_exceptions: Whether or not to propagate instrumentation exceptions to the caller. Exceptions are logged and swallowed by default.
     """
     # prevents auto-instrumentation of subprocesses if code execs another python process
     if "PYTHONPATH" in environ:
@@ -137,5 +137,5 @@ def initialize(*, reraise=False):
         _load_instrumentors(distro)
     except Exception as e:  # pylint: disable=broad-except
         _logger.exception("Failed to auto initialize OpenTelemetry")
-        if reraise:
+        if not swallow_exceptions:
             raise ValueError("Failed to auto initialize OpenTelemetry") from e

opentelemetry-instrumentation/tests/auto_instrumentation/test_initialize.py

@@ -65,8 +65,10 @@ def test_handles_exceptions(self, load_distro_mock, logger_mock):
     def test_reraises_exceptions(self, load_distro_mock, logger_mock):
         # pylint:disable=no-self-use
         load_distro_mock.side_effect = ValueError
-        with self.assertRaises(ValueError):
-            auto_instrumentation.initialize(reraise=True)
+        with self.assertRaises(ValueError) as em:
+            auto_instrumentation.initialize(swallow_exceptions=False)
             logger_mock.exception.assert_called_once_with(
                 "Failed to auto initialize OpenTelemetry"
             )
+
+        self.assertEqual("Failed to auto initialize OpenTelemetry", str(em.exception))