[Hosting] Remove obsolete methods ahead of 1.4.0 release (#4071)

* Remove obsolete methods from hosting library ahead of 1.4.0 release.

* Warning cleanup.

* CHANGELOG patch.

* Merge fixes.

* MD lint fix.

* Slim down the changes shown on the diff.

* More diff slimming.

* CHANGELOG fix.

---------

Co-authored-by: Cijo Thomas <[email protected]>
Co-authored-by: Alan West <[email protected]>

Author: 3 people

src/OpenTelemetry.Extensions.Hosting/.publicApi/netstandard2.0/PublicAPI.Unshipped.txt

@@ -1,19 +1,10 @@
 Microsoft.Extensions.DependencyInjection.OpenTelemetryServicesExtensions
-OpenTelemetry.Metrics.MeterProviderBuilderExtensions
 OpenTelemetry.OpenTelemetryBuilder
 OpenTelemetry.OpenTelemetryBuilder.ConfigureResource(System.Action<OpenTelemetry.Resources.ResourceBuilder!>! configure) -> OpenTelemetry.OpenTelemetryBuilder!
 OpenTelemetry.OpenTelemetryBuilder.Services.get -> Microsoft.Extensions.DependencyInjection.IServiceCollection!
 OpenTelemetry.OpenTelemetryBuilder.WithMetrics() -> OpenTelemetry.OpenTelemetryBuilder!
 OpenTelemetry.OpenTelemetryBuilder.WithMetrics(System.Action<OpenTelemetry.Metrics.MeterProviderBuilder!>! configure) -> OpenTelemetry.OpenTelemetryBuilder!
 OpenTelemetry.OpenTelemetryBuilder.WithTracing() -> OpenTelemetry.OpenTelemetryBuilder!
 OpenTelemetry.OpenTelemetryBuilder.WithTracing(System.Action<OpenTelemetry.Trace.TracerProviderBuilder!>! configure) -> OpenTelemetry.OpenTelemetryBuilder!
-OpenTelemetry.Trace.TracerProviderBuilderExtensions
 static Microsoft.Extensions.DependencyInjection.OpenTelemetryServicesExtensions.AddOpenTelemetry(this Microsoft.Extensions.DependencyInjection.IServiceCollection! services) -> OpenTelemetry.OpenTelemetryBuilder!
-static Microsoft.Extensions.DependencyInjection.OpenTelemetryServicesExtensions.AddOpenTelemetryMetrics(this Microsoft.Extensions.DependencyInjection.IServiceCollection! services) -> Microsoft.Extensions.DependencyInjection.IServiceCollection!
-static Microsoft.Extensions.DependencyInjection.OpenTelemetryServicesExtensions.AddOpenTelemetryMetrics(this Microsoft.Extensions.DependencyInjection.IServiceCollection! services, System.Action<OpenTelemetry.Metrics.MeterProviderBuilder!>! configure) -> Microsoft.Extensions.DependencyInjection.IServiceCollection!
-static Microsoft.Extensions.DependencyInjection.OpenTelemetryServicesExtensions.AddOpenTelemetryTracing(this Microsoft.Extensions.DependencyInjection.IServiceCollection! services) -> Microsoft.Extensions.DependencyInjection.IServiceCollection!
-static Microsoft.Extensions.DependencyInjection.OpenTelemetryServicesExtensions.AddOpenTelemetryTracing(this Microsoft.Extensions.DependencyInjection.IServiceCollection! services, System.Action<OpenTelemetry.Trace.TracerProviderBuilder!>! configure) -> Microsoft.Extensions.DependencyInjection.IServiceCollection!
-static OpenTelemetry.Metrics.MeterProviderBuilderExtensions.Configure(this OpenTelemetry.Metrics.MeterProviderBuilder! meterProviderBuilder, System.Action<System.IServiceProvider!, OpenTelemetry.Metrics.MeterProviderBuilder!>! configure) -> OpenTelemetry.Metrics.MeterProviderBuilder!
-static OpenTelemetry.Metrics.MeterProviderBuilderExtensions.GetServices(this OpenTelemetry.Metrics.MeterProviderBuilder! meterProviderBuilder) -> Microsoft.Extensions.DependencyInjection.IServiceCollection!
-static OpenTelemetry.Trace.TracerProviderBuilderExtensions.Configure(this OpenTelemetry.Trace.TracerProviderBuilder! tracerProviderBuilder, System.Action<System.IServiceProvider!, OpenTelemetry.Trace.TracerProviderBuilder!>! configure) -> OpenTelemetry.Trace.TracerProviderBuilder!
-static OpenTelemetry.Trace.TracerProviderBuilderExtensions.GetServices(this OpenTelemetry.Trace.TracerProviderBuilder! tracerProviderBuilder) -> Microsoft.Extensions.DependencyInjection.IServiceCollection!
+

src/OpenTelemetry.Extensions.Hosting/CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## Unreleased
 
+* Removed deprecated extensions: `AddOpenTelemetryTracing`,
+  `AddOpenTelemetryMetrics`, `Configure`, & `GetServices`.
+  ([#4071](https://github.com/open-telemetry/opentelemetry-dotnet/pull/4071))
+
 ## 1.4.0-rc.4
 
 Released 2023-Feb-10

src/OpenTelemetry.Extensions.Hosting/Metrics/MeterProviderBuilderExtensions.cs

@@ -52,102 +52,4 @@ public static OpenTelemetryBuilder AddOpenTelemetry(this IServiceCollection serv
 
         return new(services);
     }
-
-    /// <summary>
-    /// Configure OpenTelemetry and register a <see cref="IHostedService"/>
-    /// to automatically start tracing services in the supplied <see
-    /// cref="IServiceCollection" />.
-    /// </summary>
-    /// <remarks>
-    /// Notes:
-    /// <list type="bullet">
-    /// <item>
-    /// This is safe to be called multiple times. Only a single <see
-    /// cref="TracerProvider"/> will be created for a given <see
-    /// cref="IServiceCollection"/>.
-    /// </item>
-    /// <item>
-    /// This method should be called by application host code. Library
-    /// authors should call <see
-    /// cref="OpenTelemetryDependencyInjectionTracingServiceCollectionExtensions.ConfigureOpenTelemetryTracerProvider(IServiceCollection, Action{IServiceProvider, TracerProviderBuilder})"/>
-    /// instead.
-    /// </item>
-    /// </list>
-    /// </remarks>
-    /// <param name="services"><see cref="IServiceCollection"/>.</param>
-    /// <returns>Supplied <see cref="IServiceCollection"/> for chaining
-    /// calls.</returns>
-    [Obsolete("Use the AddOpenTelemetry().WithTracing(configure) pattern instead. This method will be removed in a future version.")]
-    public static IServiceCollection AddOpenTelemetryTracing(this IServiceCollection services)
-        => AddOpenTelemetryTracing(services, b => { });
-
-    /// <summary>
-    /// Configure OpenTelemetry and register a <see cref="IHostedService"/>
-    /// to automatically start tracing services in the supplied <see
-    /// cref="IServiceCollection" />.
-    /// </summary>
-    /// <remarks><inheritdoc
-    /// cref="AddOpenTelemetryTracing(IServiceCollection)"
-    /// path="/remarks"/></remarks>
-    /// <param name="services"><see cref="IServiceCollection"/>.</param>
-    /// <param name="configure">Callback action to configure the <see
-    /// cref="TracerProviderBuilder"/>.</param>
-    /// <returns>Supplied <see cref="IServiceCollection"/> for chaining
-    /// calls.</returns>
-    [Obsolete("Use the AddOpenTelemetry().WithTracing(configure) pattern instead. This method will be removed in a future version.")]
-    public static IServiceCollection AddOpenTelemetryTracing(this IServiceCollection services, Action<TracerProviderBuilder> configure)
-    {
-        services.AddOpenTelemetry().WithTracing(configure);
-
-        return services;
-    }
-
-    /// <summary>
-    /// Configure OpenTelemetry and register a <see cref="IHostedService"/>
-    /// to automatically start metric services in the supplied <see
-    /// cref="IServiceCollection" />.
-    /// </summary>
-    /// <remarks>
-    /// Notes:
-    /// <list type="bullet">
-    /// <item>
-    /// This is safe to be called multiple times. Only a single <see
-    /// cref="MeterProvider"/> will be created for a given <see
-    /// cref="IServiceCollection"/>.
-    /// </item>
-    /// <item>
-    /// This method should be called by application host code. Library
-    /// authors should call <see
-    /// cref="OpenTelemetryDependencyInjectionMetricsServiceCollectionExtensions.ConfigureOpenTelemetryMeterProvider(IServiceCollection, Action{IServiceProvider, MeterProviderBuilder})"/>
-    /// instead.
-    /// </item>
-    /// </list>
-    /// </remarks>
-    /// <param name="services"><see cref="IServiceCollection"/>.</param>
-    /// <returns>Supplied <see cref="IServiceCollection"/> for chaining
-    /// calls.</returns>
-    [Obsolete("Use the AddOpenTelemetry().WithMetrics(configure) pattern instead. This method will be removed in a future version.")]
-    public static IServiceCollection AddOpenTelemetryMetrics(this IServiceCollection services)
-        => AddOpenTelemetryMetrics(services, b => { });
-
-    /// <summary>
-    /// Configure OpenTelemetry and register a <see cref="IHostedService"/>
-    /// to automatically start metric services in the supplied <see
-    /// cref="IServiceCollection" />.
-    /// </summary>
-    /// <remarks><inheritdoc
-    /// cref="AddOpenTelemetryMetrics(IServiceCollection)"
-    /// path="/remarks"/></remarks>
-    /// <param name="services"><see cref="IServiceCollection"/>.</param>
-    /// <param name="configure">Callback action to configure the <see
-    /// cref="TracerProviderBuilder"/>.</param>
-    /// <returns>Supplied <see cref="IServiceCollection"/> for chaining
-    /// calls.</returns>
-    [Obsolete("Use the AddOpenTelemetry().WithMetrics(configure) pattern instead. This method will be removed in a future version.")]
-    public static IServiceCollection AddOpenTelemetryMetrics(this IServiceCollection services, Action<MeterProviderBuilder> configure)
-    {
-        services.AddOpenTelemetry().WithMetrics(configure);
-
-        return services;
-    }
 }