external prrte: Compile mpirun with PRTE_PATH to find prterun. #9963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awlauria
force-pushed
the
fix_mpirun_external_2
branch
from
3b8d3b5 to
b1b5b1b
Compare
awlauria
changed the title
bwbarrett
requested changes
Feb 3, 2022
config/ompi_setup_prrte.m4
Outdated
| @@ -95,6 +95,9 @@ AC_DEFUN([OMPI_SETUP_PRRTE],[ | |||
| AM_CONDITIONAL([OMPI_WANT_PRRTE], | |||
| [test "$prrte_setup_internal_happy" = "1" -o "$prrte_setup_external_happy" = "1"]) | |||
|
|
|||
| AM_CONDITIONAL([OMPI_EXTERNAL_PRRTE], | |||
There was a problem hiding this comment.
Why do this rather than AC_DEFINEing the data you actually want? The only time to use -D as CPPFLAGS is when you expect that variable to change between configure and build time (like some of the prefix options).
There was a problem hiding this comment.
I did it this way to limit the scope to just mpirun. I can make the change though to AC_DEFINE it.
There was a problem hiding this comment.
Traditionally, we haven't worried about that scoping. And the AM_CONDITIONAL + -D bites us in the butt just often enough to make it work avoiding.
Fixes a bug where out-of-the-box ompi builds with an external prrte will fail to find prterun. As a last resort, check this path in an attempt to find prterun. Signed-off-by: Austen Lauria <[email protected]>
awlauria
force-pushed
the
fix_mpirun_external_2
branch
from
b1b5b1b to
66c7664
Compare
bwbarrett
approved these changes
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where out-of-the-box ompi builds with an
external prrte will fail to find prterun. As a last
resort, check this path in an attempt to find prterun.
Refs: #9917
Signed-off-by: Austen Lauria [email protected]