Skip to content

v4.1.x: Patched libnbc to not round fractions based on float precision #9856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2022

Conversation

EmmanuelBRELLE
Copy link
Contributor

Applying #9852 on v4.1.x as it has been merged on master

@ompiteam-bot
Copy link

Can one of the admins verify this patch?

Signed-off-by: Emmanuel Brelle <[email protected]>
(cherry picked from commit 02d6967)
@EmmanuelBRELLE EmmanuelBRELLE force-pushed the fix_roundup_libnbc-4.1.x branch from ccb05a6 to 95dd739 Compare January 11, 2022 08:46
@jsquyres jsquyres changed the title Patched libnbc to not round fractions based on float precision v4.1.x: Patched libnbc to not round fractions based on float precision Jan 11, 2022
@jsquyres jsquyres added this to the v4.1.3 milestone Jan 11, 2022
@jsquyres jsquyres requested a review from bosilca January 11, 2022 14:54
@jsquyres
Copy link
Member

ok to test

@EmmanuelBRELLE
Copy link
Contributor Author

Is there something I can do to help merge ?
(similar PR #9852 and PR #9857 are already merged)

@jsquyres
Copy link
Member

@EmmanuelBRELLE Sorry; we're just a little behind here on merging PRs in the v4.1.x branch.

@jsquyres jsquyres merged commit c0db3d9 into open-mpi:v4.1.x Jan 25, 2022
@EmmanuelBRELLE EmmanuelBRELLE deleted the fix_roundup_libnbc-4.1.x branch February 11, 2022 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants