v5.0.x common/ofi: Utilize new libfabric API to import memhooks monitor #9303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch attempts to open up libfabric resources in order to notify libfabric when our memhooks patcher intercepts free calls. Signed-off-by: William Zhang <[email protected]> (cherry picked from commit 25811e2)
|
I still need to do the 4.1 branch cherry-pick, unfortunately I hit a segfault there so I likely have to fix something first |
|
Does this fix #8822? |
|
Yeah Austin, I mentioned it for the original patch, didn't end up mentioning it for the cherry-pick. This prevents us from trying to do memory patching twice. |
|
Turns out the segfault is just occurring in the 4.1.x branch w/o my patch...that's not good |
gpaulsen
approved these changes
Aug 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch attempts to open up libfabric resources in order to notify
libfabric when our memhooks patcher intercepts free calls.
Signed-off-by: William Zhang [email protected]
(cherry picked from commit 25811e2)