Update strings of "Open MPI" to instead use OMPI_IDENT_NAME #9249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devreal
reviewed
Aug 16, 2021
ompi/runtime/ompi_mpi_params.c
Outdated
| @@ -187,7 +187,7 @@ int ompi_mpi_register_params(void) | |||
| ompi_mpi_param_check = true; | |||
| if (!MPI_PARAM_CHECK) { | |||
| opal_output(0, "WARNING: MCA parameter mpi_no_free_handles set to true, but MPI"); | |||
| opal_output(0, "WARNING: parameter checking has been compiled out of Open MPI."); | |||
| opal_output(0, "WARNING: parameter checking has been compiled out of " OMPI_IDENT_STRING ); | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
devreal
reviewed
Aug 16, 2021
jsquyres
reviewed
Aug 16, 2021
awlauria
force-pushed
the
ident_ompi_master
branch
from
1a677ed to
6462e30
Compare
There are a number of other places to do this, but starting with this. Signed-off-by: Austen Lauria <[email protected]> Co-authored-by: Joseph Schuchart <[email protected]> Co-authored-by: Jeff Squyres <[email protected]>
awlauria
force-pushed
the
ident_ompi_master
branch
from
6462e30 to
79d7fd2
Compare
|
Fixes applied and squashed - thanks! |
|
bot:aws:retest java failure |
gpaulsen
approved these changes
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a number of other places to do this, but starting with this.
Signed-off-by: Austen Lauria [email protected]
Co-authored-by: Joseph Schuchart [email protected]
Co-authored-by: Jeff Squyres [email protected]