Skip to content

MPI4: move pcollreq into the MPI namespace #9065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 23, 2021
Merged

MPI4: move pcollreq into the MPI namespace #9065

merged 6 commits into from
Aug 23, 2021

Conversation

ggouaillardet
Copy link
Contributor

No description provided.

@ggouaillardet ggouaillardet force-pushed the topic/persistent_collective_rename branch from 1825bb4 to 76be6fc Compare June 15, 2021 14:06
@ibm-ompi
Copy link

The IBM CI (GNU/Scale) build failed! Please review the log, linked below.

Gist: https://gist.github.com/ac6d06b249bfbb022f86c9ecb4c6032f

@ibm-ompi
Copy link

The IBM CI (XL) build failed! Please review the log, linked below.

Gist: https://gist.github.com/2face426c876925b264c63fbb14c8577

@ibm-ompi
Copy link

The IBM CI (PGI) build failed! Please review the log, linked below.

Gist: https://gist.github.com/fb533447aad192d2ad4378ab2b037a57

@ibm-ompi
Copy link

The IBM CI (GNU/Scale) build failed! Please review the log, linked below.

Gist: https://gist.github.com/f88377b10eaf28d18bdd5dc6501a4d29

@ibm-ompi
Copy link

The IBM CI (XL) build failed! Please review the log, linked below.

Gist: https://gist.github.com/b12c028f4ed2de9f4dd1161e002c1425

@ggouaillardet ggouaillardet force-pushed the topic/persistent_collective_rename branch from 76be6fc to 7fc4f96 Compare June 15, 2021 23:36
@ibm-ompi
Copy link

The IBM CI (GNU/Scale) build failed! Please review the log, linked below.

Gist: https://gist.github.com/6562a5c1f2b825ab306a8241d297f479

@ggouaillardet ggouaillardet force-pushed the topic/persistent_collective_rename branch from 7fc4f96 to 5305e48 Compare June 15, 2021 23:58
@ibm-ompi
Copy link

The IBM CI (XL) build failed! Please review the log, linked below.

Gist: https://gist.github.com/c27818233f0cefef38ec0153ddf8ca0a

@ggouaillardet
Copy link
Contributor Author

:bot:aws:retest

@ibm-ompi
Copy link

The IBM CI (GNU/Scale) build failed! Please review the log, linked below.

Gist: https://gist.github.com/afac02818ba6729d93117a26f83d9bd2

@ibm-ompi
Copy link

The IBM CI (XL) build failed! Please review the log, linked below.

Gist: https://gist.github.com/87d7d72e997e6516a4df5a0f872702e5

@ggouaillardet ggouaillardet force-pushed the topic/persistent_collective_rename branch from 5305e48 to 59a3169 Compare June 16, 2021 00:20
@ibm-ompi
Copy link

The IBM CI (GNU/Scale) build failed! Please review the log, linked below.

Gist: https://gist.github.com/3d8fb5062fd7026d1330f0bcf5c27649

@ibm-ompi
Copy link

The IBM CI (XL) build failed! Please review the log, linked below.

Gist: https://gist.github.com/593f8f56c4b4d391ec635fa23dae5c94

@ggouaillardet ggouaillardet force-pushed the topic/persistent_collective_rename branch from 59a3169 to ef7cef8 Compare June 16, 2021 00:45
@ibm-ompi
Copy link

The IBM CI (PGI) build failed! Please review the log, linked below.

Gist: https://gist.github.com/a22c589d3d59d910e8793137d9de0306

@ggouaillardet
Copy link
Contributor Author

:bot:aws:retest

@ibm-ompi
Copy link

The IBM CI (GNU/Scale) build failed! Please review the log, linked below.

Gist: https://gist.github.com/7cf2435fcf2622e2d62ad4c437597650

@ibm-ompi
Copy link

The IBM CI (XL) build failed! Please review the log, linked below.

Gist: https://gist.github.com/3638a57c6208876e12f04b0fd24ea8bb

@ibm-ompi
Copy link

The IBM CI (PGI) build failed! Please review the log, linked below.

Gist: https://gist.github.com/30cff2147a4f3f9e32f3a4bc293324b2

@ggouaillardet ggouaillardet force-pushed the topic/persistent_collective_rename branch from ef7cef8 to 30a5a69 Compare June 16, 2021 01:42
@ibm-ompi
Copy link

The IBM CI (GNU/Scale) build failed! Please review the log, linked below.

Gist: https://gist.github.com/64f86af742dd94222cd81d11152cc8ce

@ggouaillardet ggouaillardet force-pushed the topic/persistent_collective_rename branch from 30a5a69 to ece963c Compare June 16, 2021 02:02
@ibm-ompi
Copy link

The IBM CI (XL) build failed! Please review the log, linked below.

Gist: https://gist.github.com/7c30b03e4dccd9608c6c1624a516055c

@ibm-ompi
Copy link

The IBM CI (GNU/Scale) build failed! Please review the log, linked below.

Gist: https://gist.github.com/292c0b57fc78f809e5e05237cdcb7af1

@ibm-ompi
Copy link

The IBM CI (XL) build failed! Please review the log, linked below.

Gist: https://gist.github.com/b3fbd1f4c677e828835cc2a973713f9b

@ibm-ompi
Copy link

The IBM CI (PGI) build failed! Please review the log, linked below.

Gist: https://gist.github.com/dcf4c53ec14a4253b8f3da86a2497bd5

@ggouaillardet ggouaillardet force-pushed the topic/persistent_collective_rename branch from ece963c to 58920ee Compare June 16, 2021 02:31
@hppritcha hppritcha mentioned this pull request Jul 29, 2021
Closed
@hppritcha
Copy link
Member

@ggouaillardet is this ready to be non-drafty?

@hppritcha
Copy link
Member

@ggouaillardet ping we'd like to merge this if its ready. Could you move it out of draft state?

@ggouaillardet
Copy link
Contributor Author

@hppritcha let me squash the commits and give it a final review

@ggouaillardet
Copy link
Contributor Author

I will update the ibm test suite to handle both MPI_ (new) and MPIX_ (old) names before I mark this PR as non drafty

@ggouaillardet ggouaillardet force-pushed the topic/persistent_collective_rename branch from 58920ee to d5b9584 Compare August 11, 2021 10:57
@jsquyres
Copy link
Member

An alternative: update the test suite to only build/run if the MPI_foo symbols are present (i.e., ignore the MPIX_foo case).

@ggouaillardet
Copy link
Contributor Author

@jsquyres that would make things easier indeed!

@ggouaillardet
Copy link
Contributor Author

Done in open-mpi/ompi-tests#151

@ggouaillardet ggouaillardet force-pushed the topic/persistent_collective_rename branch 2 times, most recently from 961dbec to 06017b0 Compare August 12, 2021 07:19
@ggouaillardet ggouaillardet marked this pull request as ready for review August 12, 2021 07:20
@ggouaillardet ggouaillardet force-pushed the topic/persistent_collective_rename branch from 06017b0 to 42220e2 Compare August 12, 2021 07:21
@ggouaillardet
Copy link
Contributor Author

@hppritcha The PR is now ready for review.
I did not squash the commits in order to ease the review process, but I will be happy to do so if needed before the merge.

Also, this PR should not be merged before open-mpi/ompi-tests#151 (otherwise non persistent collectives won't be tested at all in the master branch).

@hppritcha hppritcha merged commit 9fecace into open-mpi:master Aug 23, 2021
@kawashima-fj kawashima-fj mentioned this pull request Oct 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hppritcha hppritcha hppritcha approved these changes

Assignees
No one assigned
Labels
MPI-4.0 Target: main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ggouaillardet @ibm-ompi @hppritcha @jsquyres