master: portals4: fix include ordering and blocking #8913
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Todd Kordenbrock <[email protected]>
Signed-off-by: Todd Kordenbrock <[email protected]>
Signed-off-by: Todd Kordenbrock <[email protected]>
Signed-off-by: Todd Kordenbrock <[email protected]>
tkordenbrock
changed the title
tkordenbrock
changed the title
|
No longer relevant. Closing... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After running clang-format in #8647 and #8816, the
portals4.hheader was moved after the Portals4 component includes which caused compilation failures. This PR reorders the headers to be correct and putsportals4.hin its own header block before the Portals4 component headers.This PR fixes the ordering in portals4-btl and preemptively fixes portals4-mtl, portals4-coll and portals4-osc. Our clang-format configuration only reorders within header blocks so the headers should stay in the correct order when clang-format is run on the ompi hierarchy.