Fix unimplemented op functions for MPI_LONG. #8780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When performing an op with MPI_LONG, for example, an MPI_Allreduce() with MPI_MIN, this would segv when performing the op, since there is no longer an op function for this type. I followed the blueprint for int64_t/uint64_t. Signed-off-by: Austen Lauria <[email protected]>
|
There may be an easier/better way to do this. This comes as a result of: |
|
I just ran into this: both the osc/rdma and osc/ucx use |
|
@devreal thanks - can you confirm that this fixes the issue for you? |
|
@awlauria I can confirm that both osc/ucx and osc/rdma work with this PR 👍 |
bosilca
approved these changes
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When performing an op with MPI_LONG, for example,
an MPI_Allreduce() with MPI_MIN, this would segv when performing
the op, since there is no longer an op function
for this type.
I followed the blueprint for int64_t/uint64_t.
Signed-off-by: Austen Lauria [email protected]