spawn with info: do not erroneously free(tmp) #8777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsquyres
reviewed
Apr 6, 2021
In some cases we would issue free(tmp) on values that have not been created from asprintf, thus crashing Signed-off-by: Aurelien Bouteiller <[email protected]>
abouteiller
force-pushed
the
bugfix/spawn-info
branch
from
54c0ad3 to
d692373
Compare
abouteiller
changed the title
devreal
approved these changes
Apr 6, 2021
|
bot:retest |
jsquyres
approved these changes
Apr 6, 2021
|
I would like to see the scope of tmp more limited, since it looks like it's used in only two spots. But that's outside the scope of this pr. |
|
@abouteiller can you please cherry-pick to v5.0.x? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases we would issue free(tmp) on values that have not been created from asprintf, thus crashing
Signed-off-by: Aurelien Bouteiller [email protected]