More dynamic op cleanups #871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mewhat optimize connect/accept by using MPI bcast to distribute the participants instead of another PMIx lookup. Cleanup some Coverity issues.
jsquyres
added a commit
to jsquyres/ompi
that referenced
this pull request
Aug 23, 2016
….nid.pid.in.logical mtl-portals4: initialize endpoint nid/pid when using logical mapping
acolinisi
added a commit
to acolinisi/ompi
that referenced
this pull request
Apr 11, 2021
With the new default to link all plugins as static, the dependencies of all the plugins (e.g. transport plugins) become direct dependencies of top-level binaries (e.g. opal_wrapper aka mpicc). These direct dependencies are simply bad, because the dependency is false, it is unnecessary for running most binaries. But if that's not sufficient justification, the current default behavior is different from old behavior in a user-unfriendly way: mpicc --version mpicc: error while loading shared libraries: libugni.so.0: cannot open shared object file: No such file or directory The workaround the user needs to figure out is to build with `--enable-mca-dso` set, either for all or for a specific set of components. In PRRTE open-mpi#871 it was decided that a behavior that's more user friendly than this can be provided by implementing a smart default for which components should default to DSO compile mode. One more component that also should default to DSO is `btl-sm` but only when Cray `xpmem` is found (it is enabled by default). This would require some kind of conditional logic. See this issue for rationale: openpmix/prrte#871 This patch to OMPI is a twin to the patches that were already committed to PRRTE and PMIX: PRRTE e3914b0ad0df30939d329fe615a0ec37e64dcf2a PMIX 0b8f747 Signed-off-by: Alexei Colin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deal with connect/accept between two jobs from different mpirun's. Somewhat optimize connect/accept by using MPI bcast to distribute the participants instead of another PMIx lookup. Cleanup some Coverity issues.