coll/base: reduce memory consumption in Scatter #8626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR reduces memory consumption in non-root and non-leaf processes of binomial tree algorithm for Scatter operation. Signed-off-by: Mikhail Kurnosov <[email protected]>
bosilca
approved these changes
Mar 16, 2021
|
@mkurnosov Could you cherry-pick this to relevant release branches? Thanks! |
|
@jsquyres I have cherry-picked a commit to v4.0.x and v4.1.x. What is a preferred way to add this changes to v5.0.x? |
|
@mkurnosov please cherry-pick to the v5.0.x branch just like you have for v4.x.x branches. Thanks! |
|
Looks like #8619 is merged, so I guess you get to create a new 5.0 PR. 😄 |
|
Ah, I didn't see your response @mkurnosov . Had I seen that I would have been fine with you adding it to #8619 if possible. Sorry about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces memory consumption in non-root and non-leaf processes of binomial tree algorithm for Scatter operation.
Signed-off-by: Mikhail Kurnosov [email protected]