use-mpi-f08: fix misc bindings #8173
Conversation
ggouaillardet
commented
Nov 3, 2020
ggouaillardet
commented
- add MPI_Status_f082f() and MPI_Status_f2f08() into mpi_f08.mod
- fix missing ASYNCHRONOUS and incorrect INTENT
|
The IBM CI (XL) build failed! Please review the log, linked below. Gist: https://gist.github.com/fc9e71f7003e5b909f301ba748cd21e3 |
ggouaillardet
force-pushed
the
topic/misc_f08_bindings_fixes
branch
2 times, most recently
from
f26ef26 to
6c6f365
Compare
|
The IBM CI (XL) build failed! Please review the log, linked below. Gist: https://gist.github.com/0bdedabd0ed42d2947ad89923179524b |
ggouaillardet
force-pushed
the
topic/misc_f08_bindings_fixes
branch
from
6c6f365 to
00cf02c
Compare
|
The IBM CI (XL) build failed! Please review the log, linked below. Gist: https://gist.github.com/ea8c128ae9dd3db417ba49be9ae30cf2 |
ggouaillardet
force-pushed
the
topic/misc_f08_bindings_fixes
branch
from
00cf02c to
738cfc3
Compare
ggouaillardet
changed the title
ggouaillardet
added
Target: main
😳 Backward compat break
and removed
Target: v5.0.x
labels
ggouaillardet
force-pushed
the
topic/misc_f08_bindings_fixes
branch
3 times, most recently
from
77c891d to
e19bdb9
Compare
|
The IBM CI (XL) build failed! Please review the log, linked below. Gist: https://gist.github.com/c66851e4b783e07870de535e73fbff04 |
|
The IBM CI (PGI) build failed! Please review the log, linked below. Gist: https://gist.github.com/a95798b07d6b11e4ee03bf8bc235a418 |
ggouaillardet
force-pushed
the
topic/misc_f08_bindings_fixes
branch
from
e19bdb9 to
0508bab
Compare
ggouaillardet
force-pushed
the
topic/misc_f08_bindings_fixes
branch
3 times, most recently
from
feae8ff to
25c1749
Compare
jsquyres
force-pushed
the
topic/misc_f08_bindings_fixes
branch
from
25c1749 to
def7d98
Compare
|
Hey @ggouaillardet I just re-discovered this PR. DOH! I rebased it and fixed some easy conflicts. I also found a bunch more It wasn't entirely clear to me how you split the commits, so I just made 3 "squashme" commits at the end with the ones that still needed fixing. Could you squash these into your existing commits however is relevant? Then I think we should really merge this PR and cherry pick to v5.0.x! |
|
@jsquyres that looks good to me, feel free to squash all those commits and merge this PS |
Add missing bits from open-mpi/ompi@ab398f4 Signed-off-by: Gilles Gouaillardet <[email protected]>
- MPI_Status_f082f - MPI_Status_f2f08 Signed-off-by: Gilles Gouaillardet <[email protected]>
Add a bunch of ASYNCHRONOUSs and INTENTs that were missing. All instances of ASYNCHRONOUS were added as OMPI_ASYNCHRONOUS (and a bunch of existing instances of ASYNCHRONOUS were updated to OMPI_ASYNCHRONOUS) so that we can properly handle compilers that do not support ASYNCHRONOUS. Subroutines that had [OMPI_]ASYNCHRONOUS or INTENTs added were: - MPI_Aint_add - MPI_Aint_diff - MPI_Accumulate - MPI_Bsend_init - MPI_Comm_idup - MPI_Compare_and_swap - MPI_F_sync_reg - MPI_Fetch_and_op - MPI_File_iread* - MPI_File_iwrite* - MPI_File_read_all_begin - MPI_File_read_all_end - MPI_File_read_at_all_begin - MPI_File_read_at_all_end - MPI_File_read_ordered_begin - MPI_File_read_ordered_end - MPI_File_write_all_begin - MPI_File_write_all_end - MPI_File_write_at_all - MPI_File_write_at_all_begin - MPI_File_write_at_all_end - MPI_File_write_ordered_begin - MPI_File_write_ordered_end - MPI_Get - MPI_Get_accumulate - MPI_Get_address - MPI_Ialltoall - MPI_Ibsend - MPI_Improbe - MPI_Imrecv - MPI_Ineighbor_allgather - MPI_Ineighbor_allgatherv - MPI_Ineighbor_alltoall - MPI_Ineighbor_alltoallv - MPI_Ineighbor_alltoallw - MPI_Iprobe - MPI_Irecv - MPI_Irsend - MPI_Isend - MPI_Issend - MPI_Mprobe - MPI_Probe - MPI_Put - MPI_Raccumulate - MPI_Recv_init - MPI_Rget - MPI_Rget_accumulate - MPI_Rput - MPI_Rsend_init - MPI_Send_init - MPI_Ssend_init - MPI_Win_attach - MPI_Win_create - MPI_Win_detach - MPI_Win_get_info Subroutines that just had ASYNCHRONOUS updated to OMPI_ASYNCHRONOUS are not included in the list above. Signed-off-by: Gilles Gouaillardet <[email protected]> Signed-off-by: Jeff Squyres <[email protected]>
jsquyres
force-pushed
the
topic/misc_f08_bindings_fixes
branch
from
def7d98 to
bd2b80b
Compare
