SHMEM/SCOLL: Fix inplace reductions #8041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The IBM CI (PGI) build failed! Please review the log, linked below. Gist: https://gist.github.com/ibm-ompi/88b480fb98dfd2bdac939f023e1f8fe6 |
|
The IBM CI (GNU/Scale) build failed! Please review the log, linked below. Gist: https://gist.github.com/ibm-ompi/88b480fb98dfd2bdac939f023e1f8fe6 |
|
The IBM CI (XL) build failed! Please review the log, linked below. Gist: https://gist.github.com/ibm-ompi/88b480fb98dfd2bdac939f023e1f8fe6 |
yosefe
approved these changes
Sep 12, 2020
|
bot:ibm:retest |
|
@yosefe, ok to merge? |
yosefe
reviewed
Sep 22, 2020
oshmem/mca/scoll/mpi/scoll_mpi_ops.c
Outdated
Comment on lines
233
to
234
| if (source == target) { | ||
| sbuf = MPI_IN_PLACE; | ||
| rbuf = source; | ||
| } else { | ||
| sbuf = (void *) source; | ||
| rbuf = target; | ||
| } | ||
|
|
There was a problem hiding this comment.
sbuf = (source == target) ? MPI_IN_PLACE : source
rbuf = target
Signed-off-by: Mikhail Brinskii <[email protected]>
brminich
force-pushed
the
topic/shmem_scoll_fix
branch
from
5a89fd4 to
dfe20e0
Compare
yosefe
approved these changes
Sep 23, 2020
awlauria
added a commit
to awlauria/ompi
that referenced
this pull request
Aug 13, 2021
This was already fixed on the master/v5.0.x branch by open-mpi#8041: dfe20e0 This reverts commit 1ddcfcc. Signed-off-by: Austen Lauria <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to shmem spec source and dest arrays can be the same for reductions:
The source and dest arrays may be the same array, but they may not be overlapping arrays.If this is the case and MPI scoll is used, need to specify MPI_IN_PLACE instead of real source buffer for allreduce
Fixes openucx/ucx#5627
Signed-off-by: Mikhail Brinskii [email protected]