Correctly report TCP connect errors. #7131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bosilca
force-pushed
the
fix/tcp_errors
branch
from
a589132 to
129119e
Compare
|
The IBM CI (GNU Compiler) build failed! Please review the log, linked below. Gist: https://gist.github.com/ade4dbd8ec4062b0a3da9467e6154385 |
|
The IBM CI (XL Compiler) build failed! Please review the log, linked below. Gist: https://gist.github.com/08d34295e83c7b382d9b573204fdb804 |
jsquyres
reviewed
Oct 31, 2019
opal/mca/btl/tcp/btl_tcp_endpoint.c
Outdated
| @@ -848,7 +848,7 @@ static int mca_btl_tcp_endpoint_complete_connect(mca_btl_base_endpoint_t* btl_en | |||
| opal_show_help("help-mpi-btl-tcp.txt", "client connect fail", | |||
| true, opal_process_info.nodename, | |||
| getpid(), msg, | |||
| strerror(opal_socket_errno), opal_socket_errno); | |||
| strerror(so_erro), so_erro); | |||
There was a problem hiding this comment.
Don't you need to call getsockopt() to read the SO_ERROR value?
There was a problem hiding this comment.
Yes, that's what we do about 20 lines above. The CI error was due to a typo (because I failed my copy/paste from another terminal). Should be fixed now.
Signed-off-by: George Bosilca <[email protected]>
bosilca
force-pushed
the
fix/tcp_errors
branch
from
129119e to
4765627
Compare
jsquyres
approved these changes
Oct 31, 2019
|
@bosilca I just massaged the initial message :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove duplicate error message in TCP help.
Signed-off-by: George Bosilca [email protected]