opal: fix warning

[hjelmn]

Fixes #5713

Signed-off-by: Nathan Hjelm [email protected]

[jsquyres]

@hjelmn Note that I got a bunch of these warnings -- not just this one instance. Do you want me to post the full set locations where this warning came up on #5713?

[hjelmn]

Yup. This is all i got on my Mac.

[jsquyres]

  CC       btl_ofi_component.lo
In file included from btl_ofi_component.c:33:0:
btl_ofi.h: In function ‘mca_btl_ofi_context_trylock’:
btl_ofi.h:363:50: warning: passing argument 1 of ‘opal_thread_swap_32’ from incompatible pointer type [-Wincompatible-pointer-types]
     return (context->lock || OPAL_ATOMIC_SWAP_32(&context->lock, 1));
                                                  ^
In file included from ../../../../opal/class/opal_object.h:126:0,
                 from ../../../../opal/util/output.h:70,
                 from ../../../../opal/include/opal/types.h:43,
                 from ../../../../opal/mca/btl/btl.h:119,
                 from btl_ofi_component.c:27:
../../../../opal/threads/thread_usage.h:136:20: note: expected ‘_Atomic opal_atomic_int32_t * {aka _Atomic int *}’ but argument is of type ‘volatile int32_t * {aka volatile int *}’
 static inline type opal_thread_swap_ ## suffix (opal_atomic_ ## addr_type *ptr, type newvalue) \
                    ^
../../../../opal/threads/thread_usage.h:158:1: note: in expansion of macro ‘OPAL_THREAD_DEFINE_ATOMIC_SWAP’
 OPAL_THREAD_DEFINE_ATOMIC_SWAP(int32_t, int32_t, 32)
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  CC       btl_ofi_endpoint.lo
In file included from btl_ofi_endpoint.c:14:0:
btl_ofi.h: In function ‘mca_btl_ofi_context_trylock’:
btl_ofi.h:363:50: warning: passing argument 1 of ‘opal_thread_swap_32’ from incompatible pointer type [-Wincompatible-pointer-types]
     return (context->lock || OPAL_ATOMIC_SWAP_32(&context->lock, 1));
                                                  ^
In file included from ../../../../opal/threads/mutex.h:31:0,
                 from ../../../../opal/class/opal_pointer_array.h:34,
                 from ../../../../opal/mca/event/event.h:28,
                 from btl_ofi.h:33,
                 from btl_ofi_endpoint.c:14:
../../../../opal/threads/thread_usage.h:136:20: note: expected ‘_Atomic opal_atomic_int32_t * {aka _Atomic int *}’ but argument is of type ‘volatile int32_t * {aka volatile int *}’
 static inline type opal_thread_swap_ ## suffix (opal_atomic_ ## addr_type *ptr, type newvalue) \
                    ^
../../../../opal/threads/thread_usage.h:158:1: note: in expansion of macro ‘OPAL_THREAD_DEFINE_ATOMIC_SWAP’
 OPAL_THREAD_DEFINE_ATOMIC_SWAP(int32_t, int32_t, 32)
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  CC       btl_ofi_module.lo
In file included from btl_ofi_module.c:32:0:
btl_ofi.h: In function ‘mca_btl_ofi_context_trylock’:
btl_ofi.h:363:50: warning: passing argument 1 of ‘opal_thread_swap_32’ from incompatible pointer type [-Wincompatible-pointer-types]
     return (context->lock || OPAL_ATOMIC_SWAP_32(&context->lock, 1));
                                                  ^
In file included from ../../../../opal/class/opal_object.h:126:0,
                 from ../../../../opal/class/opal_bitmap.h:47,
                 from btl_ofi_module.c:26:
../../../../opal/threads/thread_usage.h:136:20: note: expected ‘_Atomic opal_atomic_int32_t * {aka _Atomic int *}’ but argument is of type ‘volatile int32_t * {aka volatile int *}’
 static inline type opal_thread_swap_ ## suffix (opal_atomic_ ## addr_type *ptr, type newvalue) \
                    ^
../../../../opal/threads/thread_usage.h:158:1: note: in expansion of macro ‘OPAL_THREAD_DEFINE_ATOMIC_SWAP’
 OPAL_THREAD_DEFINE_ATOMIC_SWAP(int32_t, int32_t, 32)
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  CC       btl_ofi_rdma.lo
In file included from btl_ofi_rdma.h:19:0,
                 from btl_ofi_rdma.c:14:
btl_ofi.h: In function ‘mca_btl_ofi_context_trylock’:
btl_ofi.h:363:50: warning: passing argument 1 of ‘opal_thread_swap_32’ from incompatible pointer type [-Wincompatible-pointer-types]
     return (context->lock || OPAL_ATOMIC_SWAP_32(&context->lock, 1));
                                                  ^
In file included from btl_ofi_rdma.h:17:0,
                 from btl_ofi_rdma.c:14:
../../../../opal/threads/thread_usage.h:136:20: note: expected ‘_Atomic opal_atomic_int32_t * {aka _Atomic int *}’ but argument is of type ‘volatile int32_t * {aka volatile int *}’
 static inline type opal_thread_swap_ ## suffix (opal_atomic_ ## addr_type *ptr, type newvalue) \
                    ^
../../../../opal/threads/thread_usage.h:158:1: note: in expansion of macro ‘OPAL_THREAD_DEFINE_ATOMIC_SWAP’
 OPAL_THREAD_DEFINE_ATOMIC_SWAP(int32_t, int32_t, 32)
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  CC       btl_ofi_atomics.lo
In file included from btl_ofi_rdma.h:19:0,
                 from btl_ofi_atomics.c:15:
btl_ofi.h: In function ‘mca_btl_ofi_context_trylock’:
btl_ofi.h:363:50: warning: passing argument 1 of ‘opal_thread_swap_32’ from incompatible pointer type [-Wincompatible-pointer-types]
     return (context->lock || OPAL_ATOMIC_SWAP_32(&context->lock, 1));
                                                  ^
In file included from btl_ofi_rdma.h:17:0,
                 from btl_ofi_atomics.c:15:
../../../../opal/threads/thread_usage.h:136:20: note: expected ‘_Atomic opal_atomic_int32_t * {aka _Atomic int *}’ but argument is of type ‘volatile int32_t * {aka volatile int *}’
 static inline type opal_thread_swap_ ## suffix (opal_atomic_ ## addr_type *ptr, type newvalue) \
                    ^
../../../../opal/threads/thread_usage.h:158:1: note: in expansion of macro ‘OPAL_THREAD_DEFINE_ATOMIC_SWAP’
 OPAL_THREAD_DEFINE_ATOMIC_SWAP(int32_t, int32_t, 32)
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  CC       btl_ofi_frag.lo
In file included from btl_ofi_frag.c:14:0:
btl_ofi.h: In function ‘mca_btl_ofi_context_trylock’:
btl_ofi.h:363:50: warning: passing argument 1 of ‘opal_thread_swap_32’ from incompatible pointer type [-Wincompatible-pointer-types]
     return (context->lock || OPAL_ATOMIC_SWAP_32(&context->lock, 1));
                                                  ^
In file included from ../../../../opal/threads/mutex.h:31:0,
                 from ../../../../opal/class/opal_pointer_array.h:34,
                 from ../../../../opal/mca/event/event.h:28,
                 from btl_ofi.h:33,
                 from btl_ofi_frag.c:14:
../../../../opal/threads/thread_usage.h:136:20: note: expected ‘_Atomic opal_atomic_int32_t * {aka _Atomic int *}’ but argument is of type ‘volatile int32_t * {aka volatile int *}’
 static inline type opal_thread_swap_ ## suffix (opal_atomic_ ## addr_type *ptr, type newvalue) \
                    ^
../../../../opal/threads/thread_usage.h:158:1: note: in expansion of macro ‘OPAL_THREAD_DEFINE_ATOMIC_SWAP’
 OPAL_THREAD_DEFINE_ATOMIC_SWAP(int32_t, int32_t, 32)
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  CC       btl_ofi_context.lo
In file included from btl_ofi_context.c:12:0:
btl_ofi.h: In function ‘mca_btl_ofi_context_trylock’:
btl_ofi.h:363:50: warning: passing argument 1 of ‘opal_thread_swap_32’ from incompatible pointer type [-Wincompatible-pointer-types]
     return (context->lock || OPAL_ATOMIC_SWAP_32(&context->lock, 1));
                                                  ^
In file included from ../../../../opal/threads/mutex.h:31:0,
                 from ../../../../opal/class/opal_pointer_array.h:34,
                 from ../../../../opal/mca/event/event.h:28,
                 from btl_ofi.h:33,
                 from btl_ofi_context.c:12:
../../../../opal/threads/thread_usage.h:136:20: note: expected ‘_Atomic opal_atomic_int32_t * {aka _Atomic int *}’ but argument is of type ‘volatile int32_t * {aka volatile int *}’
 static inline type opal_thread_swap_ ## suffix (opal_atomic_ ## addr_type *ptr, type newvalue) \
                    ^
../../../../opal/threads/thread_usage.h:158:1: note: in expansion of macro ‘OPAL_THREAD_DEFINE_ATOMIC_SWAP’
 OPAL_THREAD_DEFINE_ATOMIC_SWAP(int32_t, int32_t, 32)
 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  CCLD     mca_btl_ofi.la
libtool: warning: '/home/jsquyres/libfabric-current/install/lib/libfabric.la' seems to be moved

[jsquyres]

Need to fix the other warnings, too.

[hjelmn]

Got the btl/ofi one. Let me know if there are any others.