Skip to content

v2.x: mpool/base: plug a memory leak #4584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 12, 2017

Conversation

ggouaillardet
Copy link
Contributor

set the key of all mpool_tree_item objects, so they can be retrieved
in mpool_base_free and then returned back to the
mca_mpool_base_tree_item_free_list free list.

Refs. #4567

Thanks Philip Blakely for the bug report.

Signed-off-by: Gilles Gouaillardet [email protected]

(cherry picked from commit 11e5f86)

set the key of all mpool_tree_item objects, so they can be retrieved
in mpool_base_free and then returned back to the
mca_mpool_base_tree_item_free_list free list.

Refs. open-mpi#4567

Thanks Philip Blakely for the bug report.

Signed-off-by: Gilles Gouaillardet <[email protected]>

(cherry picked from commit open-mpi/ompi@11e5f86)
Copy link
Member

@hppritcha hppritcha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a NEWS update

@hppritcha
Copy link
Member

bot:ompi:retest

@ggouaillardet
Copy link
Contributor Author

ok, will do.

is this part of a new policy (e.g. cherry-pick and update NEWS) ?

how shall i start the new "chapter"

2.1.3 --
------------------------

Bug fixes/minor improvements

or

2.1.3a1 -- git
------------------------

Bug fixes/minor improvements

or something else ?

btw, should have this been added when the release and greek version were updated ?

@hppritcha
Copy link
Member

@ggouaillardet first choice is the one to use

2.1.3 --
------------------------

Bug fixes/minor improvements

We're trying to simplify life for RMs by having developers add stuff to NEWS if fixing a user reported problem.

Good point about the NEWS and when we roll version number. I'll add that to the RM release todo list.

@ggouaillardet
Copy link
Contributor Author

@hppritcha shall i update NEWS in a separate commit ? otherwise, that would not be a genuine cherry-pick ?

Plug a memory leak in MPI_Mem_free().  Thanks to Philip Blakely for reporting.

Refs open-mpi/ompi@87b2720

Signed-off-by: Gilles Gouaillardet <[email protected]>
@ggouaillardet
Copy link
Contributor Author

:bot:aws:retest

@hjelmn
Copy link
Member

hjelmn commented Dec 11, 2017

:bot:ompi:retest

@hjelmn
Copy link
Member

hjelmn commented Dec 11, 2017

@ggouaillardet I found out why this looked familiar. I fixed this in a local branch and never pushed it :).

@jsquyres
Copy link
Member

@shamisp ARMv8 testing is failing on this PR, too -- it's probably failing on all PRs... 😦

@jsquyres
Copy link
Member

@hppritcha Can you re-review?

@hppritcha
Copy link
Member

we have a configury problem with thunderx1

@bwbarrett
Copy link
Member

bot:ompi:retest

Looks like this was the ARM ThunderX / UCX issue. That builder is out of service, so let's retest...

@jsquyres jsquyres changed the title mpool/base: plug a memory leak v2.x: mpool/base: plug a memory leak Dec 12, 2017
@jsquyres jsquyres merged commit 725caf4 into open-mpi:v2.x Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants