-
Notifications
You must be signed in to change notification settings - Fork 900
v2.x: mpool/base: plug a memory leak #4584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2.x: mpool/base: plug a memory leak #4584
Conversation
set the key of all mpool_tree_item objects, so they can be retrieved in mpool_base_free and then returned back to the mca_mpool_base_tree_item_free_list free list. Refs. open-mpi#4567 Thanks Philip Blakely for the bug report. Signed-off-by: Gilles Gouaillardet <[email protected]> (cherry picked from commit open-mpi/ompi@11e5f86)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a NEWS update
bot:ompi:retest |
ok, will do. is this part of a new policy (e.g. cherry-pick and update how shall i start the new "chapter"
or
or something else ? btw, should have this been added when the |
@ggouaillardet first choice is the one to use
We're trying to simplify life for RMs by having developers add stuff to NEWS if fixing a user reported problem. Good point about the NEWS and when we roll version number. I'll add that to the RM release todo list. |
@hppritcha shall i update |
Plug a memory leak in MPI_Mem_free(). Thanks to Philip Blakely for reporting. Refs open-mpi/ompi@87b2720 Signed-off-by: Gilles Gouaillardet <[email protected]>
:bot:aws:retest |
:bot:ompi:retest |
@ggouaillardet I found out why this looked familiar. I fixed this in a local branch and never pushed it :). |
@shamisp ARMv8 testing is failing on this PR, too -- it's probably failing on all PRs... 😦 |
@hppritcha Can you re-review? |
we have a configury problem with thunderx1 |
bot:ompi:retest Looks like this was the ARM ThunderX / UCX issue. That builder is out of service, so let's retest... |
set the key of all mpool_tree_item objects, so they can be retrieved
in mpool_base_free and then returned back to the
mca_mpool_base_tree_item_free_list free list.
Refs. #4567
Thanks Philip Blakely for the bug report.
Signed-off-by: Gilles Gouaillardet [email protected]
(cherry picked from commit 11e5f86)