mpi/neighbor_allgatherv: fix copy&paste error and add helpers #3864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The IBM CI (GNU Compiler) build failed! Please review the log, linked below. Gist: https://gist.github.com/7207417c89d8eb1d72808ee3680cfe6d |
|
Something missing. Checking.... |
|
The IBM CI (XL Compiler) build failed! Please review the log, linked below. Gist: https://gist.github.com/fb0879fab8f87ce54af920375f5b8a60 |
This commit adds a helper function to get the inbound and outbound neighbor count and updates the neighbor_allgatherv bindings to use the correct count when checking the input parameters. Fixes open-mpi#2324 Signed-off-by: Nathan Hjelm <[email protected]> (cherry picked from commit 3c0e94a) Signed-off-by: Nathan Hjelm <[email protected]>
hjelmn
force-pushed
the
v2.x_neighbor_fix
branch
from
ab1f29a to
0e38f14
Compare
|
bot:mellanox:retest |
2 similar comments
|
bot:mellanox:retest |
|
bot:mellanox:retest |
|
NOTE: |
|
@ggouaillardet Can you review this PR? Thanks. |
|
@hppritcha Yes. We should also include 9b702fb. |
This commit removes the communicator topo helper functions in favor of functions in mca/topo/base. Signed-off-by: Nathan Hjelm <[email protected]> (cherry picked from commit 9b702fb) Signed-off-by: Nathan Hjelm <[email protected]>
|
@ggouaillardet Good now? |
ggouaillardet
approved these changes
Aug 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a helper function to get the inbound and outbound
neighbor count and updates the neighbor_allgatherv bindings to use the
correct count when checking the input parameters.
Fixes #2324
Signed-off-by: Nathan Hjelm [email protected]
(cherry picked from commit 3c0e94a)
Signed-off-by: Nathan Hjelm [email protected]