Update the debugger support so it properly launches under a debugger, and supports attach to a running job #3709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjhursey
approved these changes
Jun 16, 2017
orte/tools/orterun/orterun.c
Outdated
| @@ -2414,7 +2414,7 @@ static void setup_debugger_job(void) | |||
| */ | |||
| orte_plm_base_create_jobid(debugger); | |||
| /* set the personality to ORTE */ | |||
There was a problem hiding this comment.
Should probably update the comment to ompi instead of orte to reflect the line that follows.
… and supports attach to a running job Fixes #3660 Signed-off-by: Ralph Castain <[email protected]>
|
@jjhursey Done! |
|
This looks good to me, thanks! |
jsquyres
reviewed
Jun 19, 2017
| /* set the personality to ORTE */ | ||
| debugger->personality = strdup("orte"); | ||
| /* set the personality to OMPI */ | ||
| debugger->personality = strdup("ompi"); |
There was a problem hiding this comment.
@rhc54 Just curious -- why change this to "ompi" inside of orterun?
hppritcha
reviewed
Jun 19, 2017
| /* set the personality to ORTE */ | ||
| debugger->personality = strdup("orte"); | ||
| /* set the personality to OMPI */ | ||
| debugger->personality = strdup("ompi"); |
There was a problem hiding this comment.
Because you folks removed the "orte" schizo component in 2.x, so we have to default to the "ompi" one 😄
|
Do we need this fix in v3.0.x? |
|
It's already in master and 3.x - the problem was the prior branches |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to Greg Lee for the report
Fixes #3660
Signed-off-by: Ralph Castain [email protected]