fix osc rdma origin/target extent mixup -- Fixes 3569 #3570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MPI_Accumulate call has a local count/type and a target count/type and a range check was being performed with remote_count * target_extent. I changed them both to target. Signed-off-by: Mark Allen <[email protected]>
|
bot:ompi:retest Looks like the ARM builder crashed last night. |
|
This patch and #3572 are the same thing. Someone should sort that out... |
|
I'm okay with using 3572. It looks like we're both fixing the same bug. Overall this code seems to be oriented toward frequent calls to ompi_datatype_get_extent() with extent being reused and referring to whatever was its most recent call. I probably would have gone the other way with a target_extent and origin_extent calculated once, but I don't mind the existing coding style. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MPI_Accumulate call has a local count/type and a target count/type
and a range check was being performed with remote_count * target_extent.
I changed them both to target.
Signed-off-by: Mark Allen [email protected]