PML UCX: handle a synchronous send. #3347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MCA_PML_BASE_SEND_SYNCHRONOUS Signed-off-by: Alina Sklarevich <[email protected]>
yosefe
reviewed
Apr 13, 2017
ompi/mca/pml/ucx/pml_ucx.c
Outdated
| mca_pml_ucx_get_datatype(datatype), | ||
| PML_UCX_MAKE_SEND_TAG(tag, comm), | ||
| mca_pml_ucx_send_completion); | ||
| req = mca_pml_ucx_tag_send_nb(ep, buf, count, mca_pml_ucx_get_datatype(datatype), |
There was a problem hiding this comment.
can we put the BUFFERED case into that function as well?
There was a problem hiding this comment.
The BUFFERED code is a bit different so I didn't want to have the mode check twice.
There was a problem hiding this comment.
currently for regular send the mode is checked twice (one to compare to BUFFERED, second time to compare to SYNCHRONOUS. Need to avoid the extra branch and reduce code duplication
|
Please open PR's against 3.x and 2.1.x once this is merged in to master. |
Signed-off-by: Alina Sklarevich <[email protected]>
|
@yosefe @alex-mikheev Can you please review? |
yosefe
approved these changes
Apr 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MCA_PML_BASE_SEND_SYNCHRONOUS
Signed-off-by: Alina Sklarevich [email protected]