ompi: pml ucx: fix persistant request initialization #3125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Mikheev <[email protected]>
yosefe
reviewed
Mar 8, 2017
| * before the field is set. If the field is not NULL then mca_pml_ucx_preq_completion() | ||
| * will try to complete bogus persistant request. | ||
| */ | ||
| ompi_req->req_complete_cb_data = NULL; |
There was a problem hiding this comment.
should we reset it to NULL after bsend completion?
There was a problem hiding this comment.
By default (on first allocation) request memory is zeroed ? If so cleaning up after bsend will be a better approach.
There was a problem hiding this comment.
actually, now i see it is being reset on bsend completion.
yosefe
approved these changes
Mar 8, 2017
Signed-off-by: Alex Mikheev <[email protected]>
yosefe
approved these changes
Mar 8, 2017
|
@alex-mikheev pls port to 2.x/2.0.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alex Mikheev [email protected]
Fixes openucx/ucx#1361
@yosefe