v1.10: fix ompi_wrapper_script #2247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsquyres
requested changes
Oct 25, 2016
rhc54
previously approved these changes
Jan 26, 2017
|
Passing outside the 1.10.6 window |
|
@rhc54 This PR was created against the v1.10 branch -- we unfortunately can't just bump the milestone to v2.x. |
|
@ggouaillardet Can you add the signed-off-by lines to these commits? |
use @OMPI_PKG_CONFIG_LDFLAGS@ instead of @OMPI_WRAPPER_EXTRA_LDFLAGS@
so @{libdir} is substitued with ${libdir}
Thanks Manesh Nanavalla for the report
(back-ported from commit open-mpi/ompi@cb76d93)
Signed-off-by: Gilles Gouaillardet <[email protected]>
master and v1.10 have diverged regarding this script, so this is a one-off commit for the v1.10 branch Signed-off-by: Gilles Gouaillardet <[email protected]>
ggouaillardet
force-pushed
the
topic/v1.10/ompi_wrapper_script
branch
from
c309c4b to
1f15e34
Compare
|
@jsquyres both commits have been signed-off-by |
jsquyres
approved these changes
May 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.