update the error codes reported by file_delete #2238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgargabriel
force-pushed
the
pr/delete-error-codes
branch
from
6067943 to
74441b9
Compare
|
For the record, I can not reproduce the problem that I saw with the IOR benchmark last summer when using the proper error codes for MPI_File_delete. So once travis completes, I will merge this pr and file new pr to bring this commit over to 2.0.2 and 2.1 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to the discussion on the mailing list, this commit restores/fixes the error code reported by file_delete in case the file is gone.
#2232 (comment)
I will analyze the behavior of IOR before committing this though, since the IOR benchmark was the reason I changed file_delete in the first place.
signed-off: Edgar Gabriel