comm_get_name: allow MPI_COMM_NULL as argument #13276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgargabriel
force-pushed
the
topic/comm-null-name
branch
from
288386b to
5e30b90
Compare
jsquyres
reviewed
May 25, 2025
| if ( ompi_comm_invalid ( comm ) ) | ||
| /* Note that MPI 4.1. explicitely allows to invoke comm_get_name | ||
| on MPI_COMM_NULL */ | ||
| if (ompi_comm_invalid(comm) && MPI_COMM_NULL != comm) |
There was a problem hiding this comment.
Assumedly the rest of this function will work properly if MPI_COMM_NULL is passed (e.g., return the string MPI_COMM_NULL)?
There was a problem hiding this comment.
yes, I tested it :-)
MPI 4.1 explicitely allows MPI_COMM_NULL as an argument to MPI_Comm_get_name. Hence, adjust the argument checking accordingly. Fixes Issue open-mpi#12079 Signed-off-by: Edgar Gabriel <[email protected]> Co-authored-by: Jeff Squyres <[email protected]>
edgargabriel
force-pushed
the
topic/comm-null-name
branch
from
8bb26fa to
abd5c65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MPI 4.1 explicitely allows MPI_COMM_NULL as an argument to MPI_Comm_get_name. Hence, adjust the argument checking accordingly.
Fixes Issue #12079