Skip to content

Fixup #1255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 23, 2015
Merged

Fixup #1255

merged 1 commit into from
Dec 23, 2015

Conversation

annu13
Copy link
Contributor

@annu13 annu13 commented Dec 22, 2015

This PR only contains one change in file ess_base_std_orted.c, the rest of the commits are a result of some rebase and incorrect merge operations.

@artpol84
Copy link
Contributor

@annu13 this is steel incorrect.
Commit list has to be just one commit. If you need to merge you're doing something wrong.
In short you need to checkout fresh master, push it as a new branch in your fork and apply you the only one commit. and then do the PR.

@rhc54
Copy link
Contributor

rhc54 commented Dec 23, 2015

@artpol84 I don't understand your concern - there is only one commit in this PR. This looks just fine.

rhc54 pushed a commit that referenced this pull request Dec 23, 2015
@rhc54 rhc54 merged commit d7199dc into open-mpi:master Dec 23, 2015
@artpol84
Copy link
Contributor

Now it's OK. Note that @annu13 has changed the PR after my comment (according to the timeline). It wasn't OK but now it's fine.

@rhc54
Copy link
Contributor

rhc54 commented Dec 23, 2015

Ah, ok - thx!

On Tue, Dec 22, 2015 at 9:01 PM, Artem Polyakov [email protected]
wrote:

Now it's OK. Note that @annu13 https://github.com/annu13 has changed
the PR after my comment (according to the timeline). It wasn't OK but now
it's fine.


Reply to this email directly or view it on GitHub
#1255 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants