Cleanup the temporary memory allocation in collectives #1091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bosilca index 17ac951..2ee07d0 100644
--- a/ompi/mca/coll/basic/coll_basic_scan.c
+++ b/ompi/mca/coll/basic/coll_basic_scan.c
@@ -75,6 +75,7 @@ mca_coll_basic_scan_intra(const void *sbuf, void *rbuf, int count,
* receive into, later. */
dsize = opal_datatype_span(&dtype->super, count, &gap);
+ free_buffer = malloc(dsize);
if (NULL == free_buffer) {
return OMPI_ERR_OUT_OF_RESOURCE;
} |
bosilca
added a commit
to bosilca/ompi
that referenced
this pull request
Nov 22, 2015
bosilca
force-pushed
the
topic/datatype_span
branch
from
61235b3 to
fcdd20b
Compare
bosilca
added a commit
to bosilca/ompi
that referenced
this pull request
Nov 22, 2015
|
@bosilca Looks like a merge went wrong on this PR. Can you fix? |
bosilca
force-pushed
the
topic/datatype_span
branch
from
08b382e to
f137b88
Compare
bosilca
added a commit
to bosilca/ompi
that referenced
this pull request
Dec 3, 2015
some of the collective modules. Added a new function opan_datatype_span, to compute the memory span of count number of datatype, excluding the gaps in the beginning and at the end. If a memory allocation is made using the returned value, the gap (also returned) should be removed from the allocated pointer.
bosilca
force-pushed
the
topic/datatype_span
branch
from
f137b88 to
688108c
Compare
bosilca
added a commit
that referenced
this pull request
Dec 4, 2015
Cleanup the temporary memory allocation in collectives
jsquyres
pushed a commit
to jsquyres/ompi
that referenced
this pull request
Aug 23, 2016
(cherry picked from commit open-mpi/ompi@688108c)
jsquyres
pushed a commit
to jsquyres/ompi
that referenced
this pull request
Sep 19, 2016
…o-weak-symbol-fix v1.10: fortran: Fix `ompi_alloc_mem_cptr_f` linkage error
jsquyres
pushed a commit
to jsquyres/ompi
that referenced
this pull request
Sep 19, 2016
(cherry picked from commit open-mpi/ompi@688108c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup the memory handling for temporary buffers in some of the collective modules. Added a new function opal_datatype_span, to compute the memory span of count number of datatype, excluding the gaps in the beginning and at the end. If a memory allocation is made using the returned value, the gap (also returned) should be removed from the allocated pointer.
This is a second attempt of fixing this issue (follow-up on #1047)