Skip to content

SHMEM/BASE: added missing initializers #10814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

SHMEM/BASE: added missing initializers #10814

wants to merge 1 commit into from

Conversation

hoopoepg
Copy link
Contributor

  • there were missing initializers in shmem segment which caused incorrect memory access
  • added missing initializers

@hoopoepg hoopoepg requested a review from brminich September 19, 2022 11:56
@github-actions
Copy link

Hello! The Git Commit Checker CI bot found a few problems with this PR:

6c28684: SHMEM/BASE: added missing initializers

  • check_signed_off: does not contain a valid Signed-off-by line

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

@hoopoepg hoopoepg force-pushed the topic/oshmem-fixed-init branch from 6c28684 to ead854b Compare September 19, 2022 11:58
brminich
brminich reviewed Sep 19, 2022
View reviewed changes
oshmem/mca/sshmem/base/sshmem_base_wrappers.c
ds_buf->mkeys_cache = NULL;
ds_buf->mkeys = NULL;
ds_buf->alloc_hints = 0;
ds_buf->allocator = NULL;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also init context?

@hoopoepg hoopoepg force-pushed the topic/oshmem-fixed-init branch from ead854b to 6226c14 Compare September 19, 2022 14:21
@hoopoepg hoopoepg requested a review from yosefe September 20, 2022 06:15
@hoopoepg hoopoepg force-pushed the topic/oshmem-fixed-init branch from 6226c14 to 9bf5107 Compare September 20, 2022 07:39
@hoopoepg
Copy link
Contributor Author

@jsquyres is it possible to get info what is wrong with IBM tests? it failed but I can't look for failure reason.
thank you

@hoopoepg
Copy link
Contributor Author

bot:ibm:retest

@yosefe
Copy link
Contributor

yosefe commented Sep 20, 2022

@drwootton do you have access to the IBM CI failures on this PR?

@jsquyres
Copy link
Member

@jjhursey is out for a little while; he's who usually looked into IBM CI failures.

@gpaulsen @awlauria @drwootton Can you guys find out what's failing in the IBM CI on this PR?

@gpaulsen
Copy link
Member

bot:ibm:retest

@gpaulsen
Copy link
Member

I think IBM CI might need #10818 merged before we'll work again??? still trying to understand the implications.

@hoopoepg
Copy link
Contributor Author

bot:ibm:retest

1 similar comment
@awlauria
Copy link
Contributor

bot:ibm:retest

@gpaulsen gpaulsen mentioned this pull request Sep 20, 2022
Closed
@awlauria
Copy link
Contributor

bot:ibm:retest

SHMEM/BASE: added missing initializers
f6d417f 
- there were missing initializers in shmem segment
  which caused incorrect memory access
- added missing initializers

Signed-off-by: Sergey Oblomov <[email protected]>
@hoopoepg hoopoepg force-pushed the topic/oshmem-fixed-init branch from 9bf5107 to f6d417f Compare September 21, 2022 06:53
@yosefe yosefe mentioned this pull request Sep 21, 2022
Merged
@hoopoepg
Copy link
Contributor Author

closed via #10822

@hoopoepg hoopoepg closed this Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yosefe yosefe yosefe approved these changes

@brminich brminich brminich approved these changes

Assignees
No one assigned
Labels
Target: main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hoopoepg @yosefe @jsquyres @gpaulsen @awlauria @brminich