v5: Create an OPAL "core" library for internal usage #10809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes Issue open-mpi#9869 * Split `libopen-pal.so` into two libraries: - `libopen-pal_core.la` : Internal "core" portion of OPAL containing the essential source and MCA needed for mpicc/mpirun tools to link against. The "core" library is not installed. - `libopen-pal.la` : Includes "core" plus all of the other OPAL project sources. The `.so` version of this is installed. * The "core" library contains the following: - `opal/class` - `opal/mca/backtrace` - `opal/mca/dl` - `opal/mca/installdirs` - `opal/mca/threads` - `opal/mca/timer` - `opal/runtime/*_core.[c|h]` - `opal/runtime/opal_info_support.c` - `opal/util (most - see Makefile.am)` - `opal/util/keyval` * The "core" library is linked into the following tools instead of the full `libopen-pal.so`: - `ompi/tools/mpirun` - `ompi/tools/wrappers` (by extension of `opal/tools/wrappers`) - `opal/tools/wrappers` * The `opal/runtime` files were divided into a 'core' set vs 'main' set Co-authored-by: George Bosilca <[email protected]> Co-authored-by: Brian Barrett <[email protected]> Signed-off-by: Joshua Hursey <[email protected]> (cherry picked from commit fe1c384)
Signed-off-by: Joshua Hursey <[email protected]> (cherry picked from commit 8112e9b)
awlauria
approved these changes
Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libopen-pal.sointo two libraries:libopen-pal_core.la: Internal "core" portion of OPAL containing the essential source and MCA needed for mpicc/mpirun tools to link against. The "core" library is not installed.libopen-pal.la: Includes "core" plus all of the other OPAL project sources. The.soversion of this is installed.opal/classopal/mca/backtraceopal/mca/dlopal/mca/installdirsopal/mca/threadsopal/mca/timeropal/runtime/*_core.[c|h]opal/runtime/opal_info_support.copal/util (most - see Makefile.am)opal/util/keyvallibopen-pal.so:ompi/tools/mpirunompi/tools/wrappers(by extension ofopal/tools/wrappers)opal/tools/wrappersopal/runtimefiles were divided into a 'core' set vs 'main' set